Glasgow | 26-ITP-Jan | Chibuikem Okwu | Sprint 2 | Form-Controls #1105
+86
−13
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,100 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>T-Shirt Order Form</title> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>T-Shirt Sales form</h1> | ||
| <p>Please confirm your details and choose your preferred colour and size.</p> | ||
| </header> | ||
| <main> | ||
| <form aria-label="T-shirt order form"> | ||
| <br> | ||
| <!-- Customer Name --> | ||
| <div> | ||
| <label for="name">Full Name:</label> | ||
| <input | ||
| type="text" | ||
| id="name" | ||
| name="name" | ||
| minlength="2" | ||
| required | ||
| aria-required="true" | ||
| placeholder="Enter your full name" | ||
| /> | ||
| </div> | ||
| <br> | ||
| <!-- Customer Email --> | ||
|
There was a problem hiding this comment. Could you shift comment to the same indentation as div tag below? Such tags should be on the same level of indentation as it shows us which tag they relate to |
||
| <div> | ||
| <label for="email">Email Address:</label> | ||
| <input | ||
| type="email" | ||
| id="email" | ||
| name="email" | ||
| required | ||
| aria-required="true" | ||
| placeholder="Enter your email address" | ||
| /> | ||
| </div> | ||
| <br> | ||
| <!-- T-shirt Colour --> | ||
|
|
||
| <div> | ||
| <label for="colour">T-shirt Colour:</label> | ||
| <select id="colour" name="colour" required aria-required="true"> | ||
| <option value="">Select a colour</option> | ||
| <option value="black">Black</option> | ||
| <option value="white">White</option> | ||
| <option value="blue">Blue</option> | ||
| </select> | ||
| </div> | ||
| <br> | ||
| <!-- T-shirt Size --> | ||
|
|
||
| <fieldset> | ||
| <legend>T-shirt Size:</legend> | ||
| <br> | ||
| <div> | ||
| <input type="radio" id="xs" name="size" value="XS" required /> | ||
| <label for="xs">XS</label> | ||
| </div> | ||
| <br> | ||
| <div> | ||
| <input type="radio" id="s" name="size" value="S" /> | ||
| <label for="s">S</label> | ||
| </div> | ||
| <br> | ||
| <div> | ||
| <input type="radio" id="m" name="size" value="M" /> | ||
| <label for="m">M</label> | ||
| </div> | ||
| <br> | ||
| <div> | ||
| <input type="radio" id="l" name="size" value="L" /> | ||
| <label for="l">L</label> | ||
| </div> | ||
| <br> | ||
| <div> | ||
| <input type="radio" id="xl" name="size" value="XL" /> | ||
| <label for="xl">XL</label> | ||
| </div> | ||
| <br> | ||
| <div> | ||
| <input type="radio" id="xxl" name="size" value="XXL" /> | ||
| <label for="xxl">XXL</label> | ||
| </div> | ||
| <br> | ||
| </fieldset> | ||
|
|
||
| <br> | ||
| <!-- Submit Button --> | ||
|
|
||
| <button type="submit">Submit Order</button> | ||
| </form> | ||
| </main> | ||
| <br> | ||
| <footer> | ||
| <p>© 2025 Chibuikem Okwu. All rights reserved.</p> | ||
|
There was a problem hiding this comment. the copyright symbol should have ";", i.e. © |
||
| </footer> | ||
| </body> | ||
| </html> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you tell please, why do we need aria-required as we have required already?