Glasgow | ITP-Jan-2026 | Alasdair MacDonald | Sprint 2 | Form Control#1073
Open
MacDonald91 wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
Glasgow | ITP-Jan-2026 | Alasdair MacDonald | Sprint 2 | Form Control#1073MacDonald91 wants to merge 2 commits intoCodeYourFuture:mainfrom
MacDonald91 wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
MacDonald91
changed the title
This comment has been minimized.
This comment has been minimized.
MacDonald91
changed the title
MacDonald91
added
the
Needs Review
A-O-Emmanuel
left a comment
A-O-Emmanuel
left a comment
There was a problem hiding this comment.
You need to look at the task requirements and follow it.
A-O-Emmanuel
added
Reviewed
Author
|
I now have followed the correct steps required by the task list.
|
MacDonald91
added
the
Needs Review
Contributor
|
@MacDonald91 It seems you have not yet pushed the latest changes to GitHub. There is no new commits on this branch. The most recent commit "Update project", does not include the changes you mentioned:
|
A-O-Emmanuel
added
Review in progress
A-O-Emmanuel
left a comment
A-O-Emmanuel
left a comment
There was a problem hiding this comment.
I have left some comments for you.
| <legend>Choose your T-shirt</legend> | ||
|
|
||
| <label for="name">Name:</label> | ||
| <input type="text" id="name" name="name" required /> |
There was a problem hiding this comment.
can you find another way to make sure that the name is a valid name?
|
|
||
| <label for="colour">Colour:</label> | ||
| <select id="colour" name="colour" required> | ||
| <option value="">Select a colour</option> |
There was a problem hiding this comment.
select a colour should not be one of the options
|
|
||
| <label for="size">Size:</label> | ||
| <select id="size" name="size" required> | ||
| <option value="">Select a size</option> |
There was a problem hiding this comment.
select a size should not be one of the options
There was a problem hiding this comment.
You also need to ask the customer for their email, please go through the task requirements
A-O-Emmanuel
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-checklist
Changelist
Completed all the tasks, no errors.