Skip to content

Glasgow | 26-ITP-Jan | Chibuikem Okwu | Sprint 1 | Wireframe#1050

Open
chibu0070 wants to merge 23 commits intoCodeYourFuture:mainfrom
chibu0070:feature/wireframe-
Open

Glasgow | 26-ITP-Jan | Chibuikem Okwu | Sprint 1 | Wireframe#1050
chibu0070 wants to merge 23 commits intoCodeYourFuture:mainfrom
chibu0070:feature/wireframe-

Conversation

@chibu0070
Copy link

@chibu0070 chibu0070 commented Jan 24, 2026 •
edited
Loading

first pull request

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

So I have sorted all the requirements and I am waiting for a review to know if I need more changes.

Questions

No questions for now

@chibu0070
Feature/Wireframe: adjust padding and contrast
86cdaba 
based on DevTools and Lighthouse feedback
@chibu0070
adjusted CSS styl according to leon's comment's
0a860ad
@chibu0070
Feature/FormControls: add semantic HTML form
08d1ccf 
to collect name, email, colour and size
for a T-shirt order.
@chibu0070
More changes form control files
20ebe4b
@chibu0070
Tested and working code. about to commit.
ef5fe86
@chibu0070
All review on Wireframe has been completed
240fa53 
and applied needs review.
@chibu0070
Reverted form control to default
1073131
@chibu0070
Created description for the alt attributes
44b5905 
of images in the HTML file.
@chibu0070
Tried to align the grid in the article div
f4a2907 
to the left but it didn't work.
I tried different ways but nothing worked.
this is what I came up with.
@chibu0070
Used prettier to format code on save also
76082b2 
deleted aseond <body> tag
@chibu0070
Ready to pull request from feature/wireframe- to main for review
c8ecf11
@chibu0070
minor change to the image for the wireframe section.
e7ba133
@netlify
Copy link

netlify bot commented Jan 24, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 358c734
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/699097a8c79ad00008f3c093
😎 Deploy Preview https://deploy-preview-1050--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@chibu0070 chibu0070 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 24, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 3, 2026

1

A PR branch created for the Wireframe exercise should only contain changed files related to the Wireframe exercise. Can you revert the change made in the Form-Control folder?

2

A well-prepared PR makes it easier for reviewers to approve it with minimal back-and-forth.
Can you take a look at this PR Guide and General Feedback to see if there
is anything you can do to make your PR more robust and ready?
Doing so can help speed up the review process.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 3, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@chibu0070
Copy link
Author

chibu0070 commented Feb 7, 2026

I have reviewed comment 1 and have reverted the change that was in form control please review to confirm if work is complete.

1

A PR branch created for the Wireframe exercise should only contain changed files related to the Wireframe exercise. Can you revert the change made in the Form-Control folder?

2

A well-prepared PR makes it easier for reviewers to approve it with minimal back-and-forth. Can you take a look at this PR Guide and General Feedback to see if there is anything you can do to make your PR more robust and ready? Doing so can help speed up the review process.

@chibu0070
Copy link
Author

chibu0070 commented Feb 7, 2026

1

A PR branch created for the Wireframe exercise should only contain changed files related to the Wireframe exercise. Can you revert the change made in the Form-Control folder?

2

A well-prepared PR makes it easier for reviewers to approve it with minimal back-and-forth. Can you take a look at this PR Guide and General Feedback to see if there is anything you can do to make your PR more robust and ready? Doing so can help speed up the review process.

Please clarify more on the second comment. I have met all the requirements according to the style guide if I need to review all pull request and add mor information to them please let me know. @cjyuan …thanks

@chibu0070 chibu0070 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 7, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 7, 2026

This text from the PR template was part of a HTML comment and should stay hidden. Because you deleted the starting comment marker, now they are showing up in the PR description. Can you make them HTML comment again or delete them?

image

cjyuan
cjyuan reviewed Feb 7, 2026
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • According to https://validator.w3.org/, there are errors and warnings in your code. Can you fix them?

  • To better align with the wireframe, can you also make the image in articles 2 and 3 span the full width for the articles? You can leave a small gap between the image and article border (like what you did in article one).

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 7, 2026
@chibu0070
Copy link
Author

chibu0070 commented Feb 14, 2026

  • According to https://validator.w3.org/, there are errors and warnings in your code. Can you fix them?
  • To better align with the wireframe, can you also make the image in articles 2 and 3 span the full width for the articles? You can leave a small gap between the image and article border (like what you did in article one).

Yes I have fixed them.

also Aligned the bottom articles. by leaving a around the images.

@chibu0070 chibu0070 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 14, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 14, 2026

Changes look good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chibu0070 @cjyuan