-
Notifications
You must be signed in to change notification settings - Fork 6
261 Enable ad-hoc testing environments using Codespaces #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
prestoncabe
wants to merge
36
commits into
main
Choose a base branch
from
261-adhoc-testing-envs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I discovered a problem where the forwarded ports aren't public even though they need to be (and are configured to be) in codespaces. This makes it impossible to login and create a screener. You can manually make the relevant emulator ports public, but I would like to have this happen automatically. |
This reverts commit e888a67.
ff21dcb to
360295f
Compare
This reverts commit d3f976f.
Replace build-time env var patching (bin/configure-codespaces-env) with runtime URL resolution based on window.location.hostname. This correctly handles all environments: local Devbox, Devcontainer, local VS Code connected to Codespace (port-forwarded to localhost), and browser-based Codespace. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to leverage devbox config and Codespaces (built in to Github) to creating testing environments in the cloud on-demand.
Utilizes "prebuilds" to make it fast-ish.
see Codespaces Testing Guide for step-by-step instructions for how to create an ad-hoc testing environment using the changes in this PR.
Questions:
Todo:
Cleanup post-merge:
mainbranch