Open
Conversation
Uses callable workflows
1. codeforafrica 2. charterafrica
Contributor
|
Latest updated Preview URL
|
kilemensi
added
the
chore
koechkevin
reviewed
Oct 8, 2024
| @@ -1,102 +1,102 @@ | |||
| name: Code for Africa | Deploy | REVIEW APP | |||
| # name: Code for Africa | Deploy | REVIEW APP | |||
Contributor
There was a problem hiding this comment.
Are we doing away with this?
Member
Author
There was a problem hiding this comment.
Until we figure out how to make review apps work with all the apps, I'm inclined to say yes.
Contributor
|
I'm voting for this approach @kilemensi for the ease of adding a workflow for a new project. I'm thinking of edge cases that this wouldn't work and I can't find one. 🚀 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To improve the performance of our workflows, it's important to reduce duplication as much as possible. Especially if we'd need to add multi platform support to our docker images.
This PR starts the process of fine-tuning the workflows by introducing callable workflows.
Supported apps:
charterafricacodeforafricaNote
More apps will be added but to make sure the PR can be clearly reviewed and understood, 2 apps should be enough to show if this approach makes sense or not. Here is an example of how various actions are activated.
Type of change
Screenshots
Checklist: