Auto-select name for editing when creating new files/folders#2162
Open
William-Laverty wants to merge 2 commits intoCodeEditApp:mainfrom
Open
Auto-select name for editing when creating new files/folders#2162William-Laverty wants to merge 2 commits intoCodeEditApp:mainfrom
William-Laverty wants to merge 2 commits intoCodeEditApp:mainfrom
Conversation
…1729) The status bar's Line/Col information wasn't appearing until the first tab switch because tabBarTabIdSubject (a PassthroughSubject) only emitted values when selectedTab CHANGED, not its initial value. Fixed by: 1. Sending the current selectedTab value immediately in switchToActiveEditor() 2. Using dropFirst() on the publisher subscription to avoid duplicate emissions This ensures subscribers like StatusBarCursorPositionLabel receive the initial tab state when the workspace loads. Fixes CodeEditApp#1729
…tApp#2029) When creating a new file or folder in the project navigator, the name field should automatically be selected for editing, matching standard macOS UX expectations and Finder behavior. The newFileFromClipboard() function already had this behavior by calling renameFile() at the end. Applied the same pattern to newFile() and newFolder(). Fixes CodeEditApp#2029
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When creating a new file or folder in the project navigator, the name field should automatically be selected for editing. This matches standard macOS UX expectations and Finder behavior.
Problem
After creating a new file or folder, users had to manually click to rename it. This was inconsistent with the expected behavior where the name field should immediately be editable.
Solution
The
newFileFromClipboard()function already had the correct behavior by callingrenameFile()at the end. Applied the same pattern to:newFile()newFolder()Changes
renameFile()call after creating new filesrenameFile()call after creating new foldersTesting
Fixes #2029