Refactor Archiver Client for large requests#196
Merged
jacomago merged 7 commits intoChannelFinder:masterfrom Feb 18, 2026
Merged
Refactor Archiver Client for large requests#196jacomago merged 7 commits intoChannelFinder:masterfrom
jacomago merged 7 commits intoChannelFinder:masterfrom
Conversation
Collaborator
|
This does sound like a good codeathon task |
jacomago
force-pushed
the
archclient-large-input
branch
from
f0f092d to
1edb6fe
Compare
jacomago
force-pushed
the
archclient-large-input
branch
from
1edb6fe to
e9679d1
Compare
jacomago
requested review from
anderslindho,
domonkos-ess,
georgweiss,
imretoth-ess,
ralphlange,
shroffk,
simon-ess and
tynanford
src/main/java/org/phoebus/channelfinder/service/external/ArchiverService.java
Show resolved
Hide resolved
src/main/java/org/phoebus/channelfinder/service/external/ArchiverService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/phoebus/channelfinder/service/external/ArchiverService.java
Outdated
Show resolved
Hide resolved
src/test/java/org/phoebus/channelfinder/service/external/ArchiverServiceTest.java
Show resolved
Hide resolved
src/main/java/org/phoebus/channelfinder/service/external/ArchiverService.java
Outdated
Show resolved
Hide resolved
src/test/java/org/phoebus/channelfinder/service/external/ArchiverServiceTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/phoebus/channelfinder/configuration/AAChannelProcessor.java
Outdated
Show resolved
Hide resolved
georgweiss
reviewed
Feb 13, 2026
src/main/java/org/phoebus/channelfinder/configuration/AAChannelProcessor.java
Show resolved
Hide resolved
georgweiss
reviewed
Feb 13, 2026
src/test/java/org/phoebus/channelfinder/service/external/ArchiverServiceTest.java
Outdated
Show resolved
Hide resolved
georgweiss
reviewed
Feb 13, 2026
Collaborator
georgweiss
left a comment
georgweiss
left a comment
There was a problem hiding this comment.
Had some Spring Boot related comments....
jacomago
force-pushed
the
archclient-large-input
branch
from
e9679d1 to
22427d3
Compare
This was used to distinguish support for getting status via post or query Now (from an earlier merge) we explicitly configure it instead.
jacomago
force-pushed
the
archclient-large-input
branch
3 times, most recently
from
8ed48ac to
3eac53e
Compare
georgweiss
previously approved these changes
Feb 16, 2026
jacomago
force-pushed
the
archclient-large-input
branch
from
3eac53e to
2db924e
Compare
Adds Validation checking of responses from ArchiveAction s Adds a test for ArchiverService with some example responses from a live archiver
Instead of the mockresponses
jacomago
force-pushed
the
archclient-large-input
branch
2 times, most recently
from
76bb0e8 to
1e24b36
Compare
Means the integration tests won't try to autowire it
jacomago
force-pushed
the
archclient-large-input
branch
from
1e24b36 to
778ad1a
Compare
|
Contributor
Author
|
I think the failures are now due to some broken docker changes in github actions and this PR is ready @anderslindho |
anderslindho
approved these changes
Feb 18, 2026
Contributor
anderslindho
left a comment
anderslindho
left a comment
There was a problem hiding this comment.
LGTM, but - as mentioned before - would be nice if your commit messages focused more on the "why"
To come up with thoughtful commits, consider the following:
- Why have I made these changes?
- What effect have my changes made?
- Why was the change needed?
- What are the changes in reference to?
Assume the reader does not understand what the commit is addressing. They may not have access to the story addressing the detailed background of the change.
https://www.freecodecamp.org/news/how-to-write-better-git-commit-messages/
| public ArchiverService( | ||
| RestClient.Builder builder, @Value("${aa.timeout_seconds:15}") int timeoutSeconds) { | ||
| SimpleClientHttpRequestFactory factory = new SimpleClientHttpRequestFactory(); | ||
| factory.setReadTimeout(timeoutSeconds * 1000); |
Contributor
There was a problem hiding this comment.
Magic value: put 1000 in a named variable
| private List<Map<String, String>> sendRequest(Object payload, String uriString) { | ||
| try { | ||
| String response = | ||
| String values = objectMapper.writeValueAsString(payload); |
Contributor
There was a problem hiding this comment.
Should prob be outside of try-except 🔧
|
|
||
| public long configureAA(Map<ArchiveAction, List<ArchivePVOptions>> archivePVS, String aaURL) | ||
| throws JsonProcessingException { | ||
| List<String> submitArchiveAction(List<String> pvs, List<ArchivePVOptions> payload, String aaURL) { |
Contributor
There was a problem hiding this comment.
We should maybe be more careful with how we use the terms "record", "record name", "pv", "pv name" - these are all slightly different 💭
| ArchiveAction(final String endpoint) { | ||
| ArchiveAction(final String endpoint, final String successfulStatus) { | ||
| this.endpoint = endpoint; | ||
| this.successfulStatus = successfulStatus; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the Archiver Client to make sure it can stream large requests.
Swapped to the Spring boot RestClient
Added a test ArchiverServiceTest
Reduced the scope of the AAProcessorIT tests to mock the ArchiverService
For future I'd like to use openapi definition from the archiver to generate a client, maybe that's a good codathon ticket.