feat: Add pixel size estimation from registration#20
Open
Alpaca233 wants to merge 7 commits intoCephla-Lab:mainfrom
Open
feat: Add pixel size estimation from registration#20Alpaca233 wants to merge 7 commits intoCephla-Lab:mainfrom
Alpaca233 wants to merge 7 commits intoCephla-Lab:mainfrom
Conversation
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Fix silent failure in PreviewWorker: log error instead of pass - Add bounds check for expected shifts in ratio calculation - Add sanity check before applying estimated pixel size (within 50%) - Remove unused self.estimated_pixel_size variable Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add docstring entries for registration_z and registration_t parameters - Fix type hints: z_level and time_idx now Optional[int] instead of int - Update read_zarr_tile and read_zarr_region to accept z_level and time_idx - Zarr reads now respect z-level and timepoint selection instead of hardcoding Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Extract duplicated arr[np.newaxis] to single return statement in read_zarr_region - Extract pixel size application logic to helper method _apply_estimated_pixel_size Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
estimate_pixel_size()method to TileFusion that estimates true pixel size from registration resultsHow it works
For each registered tile pair:
Estimated pixel size = metadata_pixel_size × median(ratios)
Test plan
🤖 Generated with Claude Code