Add logic so that the AI will play Sylvan Library#9738
Open
marthinwurer wants to merge 7 commits intoCard-Forge:masterfrom
Open
Add logic so that the AI will play Sylvan Library#9738marthinwurer wants to merge 7 commits intoCard-Forge:masterfrom
marthinwurer wants to merge 7 commits intoCard-Forge:masterfrom
Conversation
tool4ever
reviewed
Feb 13, 2026
forge-gui-desktop/src/test/java/forge/ai/AIIntegrationTests.java
Outdated
Show resolved
Hide resolved
tool4ever
reviewed
Feb 27, 2026
Contributor
tool4ever
left a comment
tool4ever
left a comment
There was a problem hiding this comment.
mostly not in favor of a merge:
- not much investigation work seems to have been made, e.g. as long as the AI decides to filter only (which isn't even guaranteed) you're still using very simple heuristics which can easily cause more harm than good - especially in the early game
- so proving AI doesn't kill itself this way feels like roughly 10% of things to consider for this card
- I don't think that's an acceptable threshold, users will usually expect a bit more - especially when considering such an iconic card we'd just get more tickets for obvious failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to let the AI use Sylvan Library if it's in a premade deck. The AI should just use it for card filtering, like Mirri's Guile. I have a test for casting, and a test for not paying life to keep more cards.
Disclaimer: this PR was mostly written by AI (Claude Code). I have reviewed the generated code. Let me know if any changes are needed!