Skip to content

Sia v2 cleanup#259

Open
jkrick wants to merge 4 commits intoCaltech-IPAC:mainfrom
jkrick:sia_cleanup
Open

Sia v2 cleanup#259
jkrick wants to merge 4 commits intoCaltech-IPAC:mainfrom
jkrick:sia_cleanup

Conversation

@jkrick
Copy link
Contributor

@jkrick jkrick commented Feb 20, 2026

closes #240
closes #106

This completely re-works the SIA_allwise notebook to be both functional and follow what I think are best practices for accessing IRSA SIA v2 datasets. It also now conforms to the template format for this repo.

The old notebook was neither functional nor followed current best practices.

@jkrick jkrick self-assigned this Feb 20, 2026
@bsipocz
Copy link
Member

bsipocz commented Feb 20, 2026

Thank you, this looks so much nicer than the previous PR.
I would also say that we probably need to delete at least some of those notebooks as we consider this as a replacement (either even reusing the name, or simply just delete them).

We haven't done it before so it's also OK to do that in a separate PR, in case you want to keep a tally of retired/legacy notebooks, etc.

@jkrick jkrick added the content Content related issues/PRs. label Feb 20, 2026
@jkrick jkrick marked this pull request as ready for review February 20, 2026 16:38
@jkrick jkrick requested a review from bsipocz February 20, 2026 16:39
@jkrick
Copy link
Contributor Author

jkrick commented Feb 20, 2026

@bsipocz I think this is failing ci because of the firefly, but please let me know if there is also something else. And, yes, I would like to delete the other notebooks in a different PR because I want to turn one of them into a notebook with this format first.

@bsipocz
Copy link
Member

bsipocz commented Feb 20, 2026

yes, we do use FireflyClient.make_client(url="https://irsa.ipac.caltech.edu/irsaviewer") in the other notebooks and I think we should do the same here.

But @jaladh-singhal can comment on it how to proceed.

Copy link
Member

@jaladh-singhal jaladh-singhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkrick These updates should make the CI pass and make the Firefly part more clear for the tutorial readers.


We start by filtering the image results for the W3 band images.
Then look at the header of one of the resulting W3 band images of our target star.
Finally, we use the open-source astronomy data visualization software Firefly to display the fits image in a new tab.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest hyperlinking the docs here since it may not be trivial for people to understand what is Firefly and how to initialize it from Python.

Maybe something like:

Suggested change
Finally, we use the open-source astronomy data visualization software Firefly to display the fits image in a new tab.
Finally, we create an interactive FITS display of the W3 image(s) by [using Firefly](https://caltech-ipac.github.io/firefly_client/index.html), an open-source interactive visualization tool for astronomical data.
To understand how to open the Firefly viewer in a new tab from your Python notebook, refer to [this documentation](https://caltech-ipac.github.io/firefly_client/usage/initializing-vanilla.html) on how to initialize FireflyClient.```

@troyraen troyraen added content: vo services Content related issues/PRs for notebooks with an IRSA VO service relevance and removed content Content related issues/PRs. labels Feb 21, 2026
Co-authored-by: Jaladh Singhal <jaladhsinghal@gmail.com>
This was referenced Feb 24, 2026
@jkrick jkrick changed the title Sia cleanup Sia v2 cleanup Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content: vo services Content related issues/PRs for notebooks with an IRSA VO service relevance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a note to SIA notebooks clarifying v1 versus v2 BUG: fix regisry search narrative in allwise SIA example

4 participants