Skip to content

Use repository root Dockerfile, make Go cross-build robust, and fix process wait logic#63

Merged
CJackHwang merged 1 commit intodevfrom
codex/fix-issues-in-image-analysis
Feb 28, 2026
Merged

Use repository root Dockerfile, make Go cross-build robust, and fix process wait logic#63
CJackHwang merged 1 commit intodevfrom
codex/fix-issues-in-image-analysis

Conversation

@CJackHwang
Copy link
Owner

Motivation

  • Align CI release workflows to the repository root Dockerfile path so Buildx can find the Dockerfile used for multi-arch images.
  • Make the Go build in the Dockerfile robust when TARGETOS/TARGETARCH are not provided by falling back to go env values.
  • Improve build reliability by failing fast and making the build step verbose.
  • Fix incorrect child-process liveness detection in start.mjs so the script can wait for spawned processes reliably.

Description

  • Updated .github/workflows/release.yml and .github/workflows/release-dockerhub.yml to use file: ./Dockerfile instead of ./docker/Dockerfile for the docker/build-push-action.
  • Modified Dockerfile to remove hard-coded default ARG values and to compute GOOS/GOARCH with GOOS="${TARGETOS:-$(go env GOOS)}" and GOARCH="${TARGETARCH:-$(go env GOARCH)}", and replaced the go build line with a set -eux wrapper to improve error visibility.
  • Kept the multi-stage layout and artifacts but made the Go build step deterministic for both provided and absent TARGET* args.
  • Fixed waitForProcesses in start.mjs to count active processes using proc.exitCode === null && proc.signalCode === null instead of relying on p.killed.

Testing

  • Ran local multi-arch builds using docker buildx build with --platform linux/amd64,linux/arm64 against the updated Dockerfile, and image builds completed successfully.
  • Executed a local smoke test of the start script and confirmed the updated waitForProcesses correctly detects running children and resolves when they exit.
  • CI release workflows were updated to the new Dockerfile path so subsequent GitHub Actions runs will exercise the updated build steps.

Codex Task

@vercel
Copy link

vercel bot commented Feb 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ds2api Ready Ready Preview, Comment Feb 28, 2026 10:40am

@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@CJackHwang CJackHwang added codex and removed codex labels Feb 28, 2026
@CJackHwang CJackHwang merged commit b89e154 into dev Feb 28, 2026
3 checks passed
@CJackHwang CJackHwang deleted the codex/fix-issues-in-image-analysis branch February 28, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant