Use repository root Dockerfile, make Go cross-build robust, and fix process wait logic#63
Merged
CJackHwang merged 1 commit intodevfrom Feb 28, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Dockerfilepath so Buildx can find the Dockerfile used for multi-arch images.TARGETOS/TARGETARCHare not provided by falling back togo envvalues.start.mjsso the script can wait for spawned processes reliably.Description
.github/workflows/release.ymland.github/workflows/release-dockerhub.ymlto usefile: ./Dockerfileinstead of./docker/Dockerfilefor thedocker/build-push-action.Dockerfileto remove hard-coded defaultARGvalues and to computeGOOS/GOARCHwithGOOS="${TARGETOS:-$(go env GOOS)}"andGOARCH="${TARGETARCH:-$(go env GOARCH)}", and replaced thego buildline with aset -euxwrapper to improve error visibility.TARGET*args.waitForProcessesinstart.mjsto count active processes usingproc.exitCode === null && proc.signalCode === nullinstead of relying onp.killed.Testing
docker buildx buildwith--platform linux/amd64,linux/arm64against the updatedDockerfile, and image builds completed successfully.waitForProcessescorrectly detects running children and resolves when they exit.Dockerfilepath so subsequent GitHub Actions runs will exercise the updated build steps.Codex Task