Open
Conversation
added 30 commits
June 27, 2025 01:14
added 25 commits
June 27, 2025 01:14
There was a problem hiding this comment.
Pull Request Overview
This PR adds CTT support and upgrades multiple components – both in the storage/cache layer and in many of the process plugins – by replacing integer-based return codes with a new enumerated type (ProcessPlugin::FlowAction). In addition, it introduces new modules (e.g. cache-ctt) to handle offload and export via CTT and adapts many plugin files accordingly.
Reviewed Changes
Copilot reviewed 104 out of 105 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/plugins/storage/cache/.hpp,.cpp | Inlined “inline” keyword for operators and minor refactoring in time/value handling. |
| src/plugins/storage/cache-ctt/* | New CTT support code, including controller, remove queue, and extension of the hash table cache. |
| src/plugins/process/* | Refactored plugin functions to return ProcessPlugin::FlowAction instead of int, ensuring consistent API calls. |
| CMakeLists.txt files | Updated build definitions (e.g. enabling “maybe_virtual”) and linking to new telemetry/CTT libraries. |
Comments suppressed due to low confidence (2)
src/plugins/process/tls/src/tls.cpp:393
- [nitpick] There is commented-out code offering an alternative assignment for rec->version. If this alternative is no longer needed, consider removing it or adding a comment to clarify its purpose to improve code readability.
//rec->version = parser.get_supported_versions().empty() ? parser.get_handshake()->version.version
src/plugins/process/netbios/src/netbios.cpp:83
- The previous implementation incremented total_netbios_packets when adding a NETBIOS extension; however, the new diff omits this counter update. Please verify whether this change is intentional, or if the counter should still be updated to maintain accurate metrics.
total_netbios_packets++;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.