Skip to content

Comments

Add 'day of week' effect as argument to Count observation process constructor#718

Open
cdc-mitzimorris wants to merge 24 commits intomainfrom
mem_712_day_of_week
Open

Add 'day of week' effect as argument to Count observation process constructor#718
cdc-mitzimorris wants to merge 24 commits intomainfrom
mem_712_day_of_week

Conversation

@cdc-mitzimorris
Copy link
Collaborator

Adds a day of week effect to a count observation process, per discussion in issue #712.

This PR includes implementation, unit tests, and tutorial. The tutorial uses the tutorial plot theme docs/tutorials/_tutorial_theme.py and therefore the docs won't render until PR #711 is approved and merged.

To implement this, I had Claude review the issue, the existing code base, and the way that day of week effects are calculated/used in pyrenew-multisignal. I reviewed all code edits manually and ran the tutorial notebook in jupyter.

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.82%. Comparing base (923fda8) to head (e9e138d).

Files with missing lines Patch % Lines
pyrenew/model/multisignal_model.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #718      +/-   ##
==========================================
- Coverage   97.91%   97.82%   -0.09%     
==========================================
  Files          51       51              
  Lines        1580     1607      +27     
==========================================
+ Hits         1547     1572      +25     
- Misses         33       35       +2     
Flag Coverage Δ
unittests 97.82% <92.59%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant