Add 'day of week' effect as argument to Count observation process constructor#718
Open
cdc-mitzimorris wants to merge 24 commits intomainfrom
Open
Add 'day of week' effect as argument to Count observation process constructor#718cdc-mitzimorris wants to merge 24 commits intomainfrom
cdc-mitzimorris wants to merge 24 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #718 +/- ##
==========================================
- Coverage 97.91% 97.82% -0.09%
==========================================
Files 51 51
Lines 1580 1607 +27
==========================================
+ Hits 1547 1572 +25
- Misses 33 35 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a day of week effect to a count observation process, per discussion in issue #712.
This PR includes implementation, unit tests, and tutorial. The tutorial uses the tutorial plot theme
docs/tutorials/_tutorial_theme.pyand therefore the docs won't render until PR #711 is approved and merged.To implement this, I had Claude review the issue, the existing code base, and the way that day of week effects are calculated/used in pyrenew-multisignal. I reviewed all code edits manually and ran the tutorial notebook in jupyter.