Make the "port forwarding delete" command idempotent#90
Merged
tzumainn merged 1 commit intoCCI-MOC:masterfrom May 28, 2025
Merged
Make the "port forwarding delete" command idempotent#90tzumainn merged 1 commit intoCCI-MOC:masterfrom
tzumainn merged 1 commit intoCCI-MOC:masterfrom
Conversation
Previously, attempting to delete a port forwarding that does not exist
would fail with:
$ uv run openstack esi port forwarding delete 172.17.1.106 128.31.20.118 -p 80
'could not find port forwarding matching 80:80/tcp'
$ echo $?
1
With this change, we log a warning but do not consider it an error:
$ uv run openstack esi port forwarding delete 172.17.1.106 128.31.20.118 -p 80
port forwarding matching 80:80/tcp does not exist
$ echo $?
0
tzumainn
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, attempting to delete a port forwarding that does not exist
would fail with:
With this change, we log a warning but do not consider it an error: