Skip to content

fixing nonembedded meta in virtual_db; #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmatKhan wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fixing nonembedded meta in virtual_db; #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions tfbpapi/virtual_db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,8 +848,16 @@ def add_col(col: str) -> None:
prop_result = self._resolve_property_columns(repo_id, config_name)
if prop_result is not None:
derived_exprs, prop_raw_cols = prop_result
# Ensure source columns needed by expressions are selected
for col in prop_raw_cols:
# Ensure source columns needed by expressions are selected.
# For external metadata datasets, restrict to columns that are
# physically present in the metadata parquet -- data columns
# (e.g. target_locus_tag) must not bleed into the meta view.
allowed_raw_cols = (
[c for c in prop_raw_cols if c in actual_meta_cols]
if is_external
else prop_raw_cols
)
for col in allowed_raw_cols:
add_col(col)
# Qualify source column references inside CASE WHEN expressions
if is_join:
Expand Down
Loading