Use New Parameter For Event Merging: --min-event-dist#200
Draft
Breakthrough wants to merge 3 commits intomainfrom
Draft
Use New Parameter For Event Merging: --min-event-dist#200Breakthrough wants to merge 3 commits intomainfrom
--min-event-dist#200Breakthrough wants to merge 3 commits intomainfrom
Conversation
This reduces the area of effect for these parameters, and reduces complexity of the actual scanning pipeline.
Owner
Author
|
I think the most realistic way to approach this is to rewrite the scan logic of Unfortunately this may need to be bumped to v1.8 however. |
d40559b to
d8f084d
Compare
6ffa59e to
5cefd51
Compare
a38ce9d to
5711a36
Compare
904dc78 to
6e7e0ef
Compare
36b111d to
cea454e
Compare
41baa78 to
80b931a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes how event merging works, fixing #72 and #192:
time-before-event(-tb) andtime-post-event(-tp) options--min-event-dist), which controls how long after a motion event starts we continue appending frames with motion.