Skip to content

Cilbox networking shim access in props #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dooly123 merged 2 commits into from
Mar 1, 2026
Merged

Cilbox networking shim access in props #561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13abc79
Rename ServerOwnershipDestroyed methods for consistency and clarity
Mr-Zero88 Mar 1, 2026
3043da0
Add BasisNetworkShim to whitelist types in CilboxPropBasis
Mr-Zero88 Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Basis/Packages/com.basis.framework/Networking/BasisNetworkBehaviour/BasisNetworkBehaviour.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ private void LowLevelOwnershipReleased(string uniqueEntityID)
{
if (uniqueEntityID == clientIdentifier)
{
ServerOwnershipDestroyed();
OnServerOwnershipDestroyed();
}
}
private void LowLevelOwnershipTransfer(string uniqueEntityID, ushort NetIdNewOwner, bool isOwner)
Expand Down Expand Up @@ -276,7 +276,7 @@ public virtual void OnNetworkReady()
/// <summary>
/// back to no one owning it, (item no longer exists for example)
/// </summary>
public virtual void ServerOwnershipDestroyed()
public virtual void OnServerOwnershipDestroyed()
{

}
Expand Down
6 changes: 3 additions & 3 deletions Basis/Packages/com.basis.shim/Shims/BasisNetworkShim.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public class BasisNetworkShim : BasisNetworkBehaviour

public NetworkReadyEvent NetworkReady { set; get; }
public OwnershipTransferEvent OwnershipTransfer { set; get; }
public ServerOwnershipDestroyedEvent ServerOwnershipDestroyedE { set; get; }
public ServerOwnershipDestroyedEvent ServerOwnershipDestroyed { set; get; }
public NetworkMessageEvent NetworkMessageReceived { set; get; }
public PlayerLeftEvent PlayerLeft { set; get; }
public PlayerJoinedEvent PlayerJoined { set; get; }
Expand All @@ -27,9 +27,9 @@ public override void OnNetworkReady()
{
NetworkReady?.Invoke();
}
public override void ServerOwnershipDestroyed()
public override void OnServerOwnershipDestroyed()
{
ServerOwnershipDestroyedE?.Invoke();
ServerOwnershipDestroyed?.Invoke();
}
public override void OnOwnershipTransfer(BasisNetworkPlayer NetNewOwner)
{
Expand Down
19 changes: 18 additions & 1 deletion Basis/Packages/com.basis.shim/Shims/CilboxPropBasis.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,21 @@ public class CilboxPropBasis : Cilbox
"Basis.Scripts.BasisSdk.Interactions.BasisPickUpUseMode",
"Basis.Scripts.Device_Management.Devices.BasisInput", // Restrictive, only used as a type.
"Basis.Scripts.BasisSdk.Interactions.BasisPickupInteractable", // Restrictive (See below), only access field.
"Basis.Scripts.BasisSdk.Interactions.BasisInteractableObject",
"Basis.Scripts.BasisSdk.Interactions.BasisInteractableObject", // Restrictive (See below), only access field.
"Basis.BasisInteractableShim",
"Basis.BasisInteractableShim+ClickEvent",
"Basis.BasisNetworkBehaviour",
"Basis.BasisNetworkShim",
"Basis.BasisNetworkShim+NetworkMessageEvent",
"Basis.BasisNetworkShim+NetworkReadyEvent",
"Basis.BasisNetworkShim+OwnershipTransferEvent",
"Basis.BasisNetworkShim+PlayerJoinedEvent",
"Basis.BasisNetworkShim+PlayerLeftEvent",
"Basis.BasisNetworkShim+ServerOwnershipDestroyedEvent",
"Basis.Network.Core.DeliveryMethod",
"Basis.SafeUtil",
"Basis.Scripts.BasisSdk.Players.BasisLocalPlayer",
"Basis.Scripts.Networking.NetworkedAvatar.BasisNetworkPlayer",

// Cilbox types
"Cilbox.CilboxPublicUtils",
Expand Down Expand Up @@ -99,6 +113,8 @@ public class CilboxPropBasis : Cilbox
"Basis.Scripts.BasisSdk.Interactions.BasisPickupInteractable.OnPickupUse",
"Basis.Scripts.BasisSdk.Interactions.BasisInteractableObject.OnInteractStartEvent",
"Basis.Scripts.BasisSdk.Interactions.BasisInteractableObject.OnInteractEndEvent",
"Basis.BasisNetworkBehaviour.CurrentOwnerId",
"Basis.BasisNetworkBehaviour.IsOwnedLocallyOnServer",
};

static public HashSet<String> GetWhiteListTypes() { return whiteListType; }
Expand All @@ -125,6 +141,7 @@ override public bool CheckFieldAllowed( String sType, String sFieldName )
{ typeof(UnityEngine.MonoBehaviour), new HashSet<string>{ ".ctor" } },
{ typeof(UnityEngine.Events.UnityAction), new HashSet<string>{ ".ctor" } },
{ typeof(Basis.Scripts.BasisSdk.Interactions.BasisPickupInteractable), new HashSet<string> { } },
{ typeof(Basis.Scripts.BasisSdk.Interactions.BasisInteractableObject), new HashSet<string> { } },
{ typeof(Basis.Scripts.Device_Management.Devices.BasisInput), new HashSet<string> { } },
{ typeof(UnityEngine.GameObject), new HashSet<string>{ nameof(GameObject.SetActive), nameof(GameObject.GetComponents) } },
{ typeof(System.Type), new HashSet<string>() }, // nothing allowed
Expand Down
4 changes: 2 additions & 2 deletions Basis/Packages/com.basis.shim/Shims/CilboxSceneBasis.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ public class CilboxSceneBasis : Cilbox
"Basis.BasisNetworkShim+PlayerJoinedEvent",
"Basis.BasisNetworkShim+PlayerLeftEvent",
"Basis.BasisNetworkShim+ServerOwnershipDestroyedEvent",
"Basis.BasisUrl",
"Basis.IBasisImageDownload",
"Basis.Network.Core.DeliveryMethod",
"Basis.SafeUtil",
"Basis.Scripts.BasisSdk.Players.BasisLocalPlayer",
"Basis.Scripts.Networking.NetworkedAvatar.BasisNetworkPlayer",
"Basis.BasisUrl",
"Basis.IBasisImageDownload",
"BasisNetworkCommon+EventTiming",
"BasisSDKMirror",
"BasisSDKMirror+MirrorClearFlags",
Expand Down
Loading