Draft
Conversation
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 96.85% 96.48% -0.38%
==========================================
Files 49 49
Lines 3113 3126 +13
Branches 566 568 +2
==========================================
+ Hits 3015 3016 +1
- Misses 97 109 +12
Partials 1 1
Continue to review full report at Codecov.
|
added 2 commits
June 16, 2020 10:22
…to xarray. Module is called NdaarayToXarray
|
Hello @gkbal! Thanks for updating your pull request.
Comment last updated at 2020-07-20 05:10:43 UTC |
rocco8773
requested changes
Jun 30, 2020
bapsflib/utils/__init__.py
Outdated
| def foo(x): | ||
| return x | ||
| def NdarrayToXarray(data, arr_name={}): | ||
| import xarray as xr |
Member
There was a problem hiding this comment.
move between __all__ and the "from" imports
All imports should be at the top of the file, unless you're trying to avoid things like cyclical imports.
change module name Co-authored-by: Erik Everson <eteverson@gmail.com>
"shot_index" to "shotnum" Co-authored-by: Erik Everson <eteverson@gmail.com>
"shot_index" to "shotnum" 2 Co-authored-by: Erik Everson <eteverson@gmail.com>
…psflib into UnderConstruction_bapsf � Conflicts: � bapsflib/utils/__init__.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numpy to xarray converter