Add Docker-based workflow setup, environment fixes, and improved .gitignore#37
Draft
Sarbani-Roy wants to merge 11 commits intomainfrom
Draft
Add Docker-based workflow setup, environment fixes, and improved .gitignore#37Sarbani-Roy wants to merge 11 commits intomainfrom
Sarbani-Roy wants to merge 11 commits intomainfrom
Conversation
…linderMerge remote-tracking branch 'origin/main' into dumux_and_rotating_cylinder @
joergfunger
reviewed
Dec 11, 2025
Member
joergfunger
left a comment
There was a problem hiding this comment.
Thanks for the update, let's discuss the details today in the meeting. But I would say adding the complete DUMUX source code to this repo here is not optimal. In addition, docker is not allowed in our environments (it requires root access) as such an alternative would be to use singularity. I would also suggest to generally make an issue first before doing complex implementation changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge request introduces a complete setup for running the NFDI4IngModelValidationPlatform on macOS via Docker, including fixes for architecture-related issues and updates to workflow configuration.
Key changes
Why this is needed