Skip to content

feat: add 7 Spector easy-win scenarios for Sprint 1#892

Open
RickWinter wants to merge 3 commits intoAzure:mainfrom
RickWinter:squad/sprint1-spector-easy-wins
Open

feat: add 7 Spector easy-win scenarios for Sprint 1#892
RickWinter wants to merge 3 commits intoAzure:mainfrom
RickWinter:squad/sprint1-spector-easy-wins

Conversation

@RickWinter
Copy link
Member

Wire up 7 new Spector test crate scenarios that the emitter already supports without code changes:

  • authentication/noauth
  • documentation
  • encode/array
  • parameters/query
  • type/model/inheritance/recursive
  • azure/client-generator-core/access
  • azure/client-generator-core/client-default-value

3 of the original 10 planned scenarios need emitter work:

  • type/union (basic) - non-discriminated unions not supported
  • type/property/additional-properties - non-discriminated unions
  • type/model/inheritance/nested-discriminator - name collision bug

Copilot AI review requested due to automatic review settings March 6, 2026 17:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds 7 new Spector test crate scenarios to the typespec-rust emitter test suite. These are "easy-win" scenarios that the existing emitter already supports without code changes. The PR also notes 3 additional planned scenarios that still require emitter work (type/union, additional-properties, nested-discriminator).

Changes:

  • Added 7 new generated Rust crate scenarios: authentication/noauth/union, documentation, encode/array, parameters/query, type/model/inheritance/recursive, azure/client-generator-core/access, and azure/client-generator-core/client-default-value.
  • Registered the new crates in the workspace Cargo.toml, Cargo.lock, and the tspcompile.js build script.
  • Uncommented previously-commented-out entries in tspcompile.js for spector_recursive and spector_access, and added a new comment for spector_nesteddisc as a future TODO.

Reviewed changes

Copilot reviewed 23 out of 111 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/typespec-rust/.scripts/tspcompile.js Register 7 new crate-to-spec mappings and uncomment 2 previously disabled entries
packages/typespec-rust/test/Cargo.toml Add 7 new workspace member crates
packages/typespec-rust/test/Cargo.lock Lock file updates for the 7 new crate dependencies
authentication/noauth/union/ (all files) Generated client for NoAuth+OAuth2 union authentication scenario
documentation/ (all files) Generated clients/models for documentation text formatting and lists scenarios
encode/array/ (all files) Generated clients/models for array encoding with various delimiters and enum types
parameters/query/ (all files) Generated client for constant query parameter scenario
type/model/inheritance/recursive/ (all files) Generated client/model for recursive model inheritance
azure/client-generator-core/access/ (all files) Generated clients/models for access control (public, internal, shared, relative) scenarios
azure/client-generator-core/client-default-value/ (all files) Generated client/model for client default values on parameters and properties

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jhendrixMSFT jhendrixMSFT force-pushed the squad/sprint1-spector-easy-wins branch 2 times, most recently from 50cf95d to 8abc342 Compare March 6, 2026 18:43
Copilot and others added 3 commits March 6, 2026 10:51
Wire up 7 new Spector test crate scenarios that the emitter
already supports without code changes:
- authentication/noauth
- documentation
- encode/array
- parameters/query
- type/model/inheritance/recursive
- azure/client-generator-core/access
- azure/client-generator-core/client-default-value

3 of the original 10 planned scenarios need emitter work:
- type/union (basic) - non-discriminated unions not supported
- type/property/additional-properties - non-discriminated unions
- type/model/inheritance/nested-discriminator - name collision bug

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jhendrixMSFT jhendrixMSFT force-pushed the squad/sprint1-spector-easy-wins branch from 8abc342 to 7dccbe5 Compare March 6, 2026 20:05
@jhendrixMSFT
Copy link
Member

I don't see any tests for these scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants