feat: add 7 Spector easy-win scenarios for Sprint 1#892
Open
RickWinter wants to merge 3 commits intoAzure:mainfrom
Open
feat: add 7 Spector easy-win scenarios for Sprint 1#892RickWinter wants to merge 3 commits intoAzure:mainfrom
RickWinter wants to merge 3 commits intoAzure:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds 7 new Spector test crate scenarios to the typespec-rust emitter test suite. These are "easy-win" scenarios that the existing emitter already supports without code changes. The PR also notes 3 additional planned scenarios that still require emitter work (type/union, additional-properties, nested-discriminator).
Changes:
- Added 7 new generated Rust crate scenarios:
authentication/noauth/union,documentation,encode/array,parameters/query,type/model/inheritance/recursive,azure/client-generator-core/access, andazure/client-generator-core/client-default-value. - Registered the new crates in the workspace
Cargo.toml,Cargo.lock, and thetspcompile.jsbuild script. - Uncommented previously-commented-out entries in
tspcompile.jsforspector_recursiveandspector_access, and added a new comment forspector_nesteddiscas a future TODO.
Reviewed changes
Copilot reviewed 23 out of 111 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
packages/typespec-rust/.scripts/tspcompile.js |
Register 7 new crate-to-spec mappings and uncomment 2 previously disabled entries |
packages/typespec-rust/test/Cargo.toml |
Add 7 new workspace member crates |
packages/typespec-rust/test/Cargo.lock |
Lock file updates for the 7 new crate dependencies |
authentication/noauth/union/ (all files) |
Generated client for NoAuth+OAuth2 union authentication scenario |
documentation/ (all files) |
Generated clients/models for documentation text formatting and lists scenarios |
encode/array/ (all files) |
Generated clients/models for array encoding with various delimiters and enum types |
parameters/query/ (all files) |
Generated client for constant query parameter scenario |
type/model/inheritance/recursive/ (all files) |
Generated client/model for recursive model inheritance |
azure/client-generator-core/access/ (all files) |
Generated clients/models for access control (public, internal, shared, relative) scenarios |
azure/client-generator-core/client-default-value/ (all files) |
Generated client/model for client default values on parameters and properties |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
50cf95d to
8abc342
Compare
Wire up 7 new Spector test crate scenarios that the emitter already supports without code changes: - authentication/noauth - documentation - encode/array - parameters/query - type/model/inheritance/recursive - azure/client-generator-core/access - azure/client-generator-core/client-default-value 3 of the original 10 planned scenarios need emitter work: - type/union (basic) - non-discriminated unions not supported - type/property/additional-properties - non-discriminated unions - type/model/inheritance/nested-discriminator - name collision bug Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
8abc342 to
7dccbe5
Compare
Member
|
I don't see any tests for these scenarios. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire up 7 new Spector test crate scenarios that the emitter already supports without code changes:
3 of the original 10 planned scenarios need emitter work: