Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates azure-ai-projects test coverage around recorded scenarios by re-enabling previously skipped browser automation telemetry tests and adjusting sample test execution to cover additional recorded cases, alongside updating the assets tag to point at the new recording set.
Changes:
- Enable an additional parametrized sample test case for
sample_agent_azure_function.pywith the required storage-related env vars. - Re-enable browser automation Responses instrumentor tests (sync + async) by removing class-level
pytest.mark.skip. - Update
assets.jsontag to reference the latest recordings.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
sdk/ai/azure-ai-projects/tests/samples/test_samples.py |
Adds additionalSampleTests for the Azure Function sample and re-includes browser automation sample in the main sample run set. |
sdk/ai/azure-ai-projects/tests/agents/telemetry/test_responses_instrumentor_browser_automation.py |
Removes the skip marker so browser automation telemetry recordings are exercised again. |
sdk/ai/azure-ai-projects/tests/agents/telemetry/test_responses_instrumentor_browser_automation_async.py |
Removes the skip marker so async browser automation telemetry recordings are exercised again. |
sdk/ai/azure-ai-projects/assets.json |
Points the package to the updated azure-sdk-assets tag containing the refreshed recordings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines