{sqlvm} Migrate validator function from calling Compute module to aaz-based implementation#32964
Open
william051200 wants to merge 3 commits intoAzure:devfrom
Open
{sqlvm} Migrate validator function from calling Compute module to aaz-based implementation#32964william051200 wants to merge 3 commits intoAzure:devfrom
william051200 wants to merge 3 commits intoAzure:devfrom
Conversation
❌AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
calvinhzy,
evelyn-ys and
yonzhan
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the SQL VM Azure AD auth validator away from the mgmt.compute SDK usage into an AAZ-based VM retrieval path, with updated test recordings to reflect the new underlying Compute API version.
Changes:
- Replaced
ResourceType.MGMT_COMPUTEclient usage withVMShow(AAZ) to fetch VM identity data. - Updated VM identity parsing to use dict/camelCase fields (
principalId,userAssignedIdentities, etc.). - Refreshed test recordings to use a newer Compute
api-version.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/sqlvm/_validators.py | Switches VM lookup from mgmt SDK to AAZ VMShow and updates identity field access accordingly. |
| src/azure-cli/azure/cli/command_modules/sqlvm/tests/latest/recordings/test_sqlvm_aad_auth_negative.yaml | Updates recorded Compute VM GET requests to a newer api-version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| from azure.cli.core.commands.client_factory import get_mgmt_service_client | ||
| from azure.cli.core.profiles import ResourceType | ||
| compute_client = get_mgmt_service_client(cli_ctx, ResourceType.MGMT_COMPUTE) | ||
| from ..vm.operations.vm import VMShow |
Comment on lines
+256
to
+259
| vm = VMShow(cli_ctx=cli_ctx)(command_args={ | ||
| 'resource_group': namespace.resource_group_name, | ||
| 'vm_name': namespace.sql_virtual_machine_name | ||
| }) |
Comment on lines
+278
to
+280
| for umi in vm['identity']['userAssignedIdentities'].keys(): | ||
| if vm['identity']['userAssignedIdentities'][umi]['clientId'] == namespace.msi_client_id: | ||
| return vm['identity']['userAssignedIdentities'][umi]['principalId'] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
sql vm enable-azure-ad-authsql vm validate-azure-ad-authDescription
Migration from mgmt.compute to aaz-based
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.