fix: standardize pt at infinity before setting public #20431
+15
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ledwards2225
approved these changes
Feb 12, 2026
Contributor
ledwards2225
left a comment
ledwards2225
left a comment
There was a problem hiding this comment.
LGTM. Only missing piece in my mind is stdlib serialize_to_fields. As we've discussed, it seems true that we won't run into issues here with current usage but I'm not sure there's anything structurally preventing it. Maybe a simple ASSERT protecting against inf in that method would do?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are setting public a result of a biggroup computation, make sure pt at infinity is (0,0)