fix(txe): use empty scopes for zero address and add ContractSyncService tests #20425
+234
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchamo
commented
Feb 12, 2026
| const effectiveScopes = from.isZero() ? undefined : [from]; | ||
| // When `from` is the zero address (e.g. when deploying a new account contract), we return an | ||
| // empty scope list which acts as deny-all: no notes are visible and no keys are accessible. | ||
| const effectiveScopes = from.isZero() ? [] : [from]; |
Contributor
Author
There was a problem hiding this comment.
We are now making it consistent with the PXE
benesjan
approved these changes
Feb 12, 2026
Contributor
benesjan
left a comment
benesjan
left a comment
There was a problem hiding this comment.
Looks good!
Just note that when testing you want to test external behavior and not irrelevant implementation details. AI sometimes over-tests and writes superfluous tests testing implementation details. So it's good to clear these useless test cases.
yarn-project/pxe/src/contract_sync/contract_sync_service.test.ts
Outdated
Show resolved
Hide resolved
…ce tests ## Summary - **TXE scope fix**: When `from` is the zero address, TXE now returns `[]` (empty scopes, deny-all) instead of `undefined` (allow-all). This matches the behavior of `BaseWallet.scopesFor()` in the PXE/wallet path, where the zero address produces an empty scope list that causes `ensureContractSynced` to skip sync entirely. - **ContractSyncService tests**: Adds 19 unit tests covering scope-aware caching, cache invalidation (wipe/discard), overrides, concurrency, and error handling. Co-authored-by: Nicolas Chamo <nicolas@chamo.com.ar>
AztecBot
force-pushed
the
feat/contract-sync-tests-and-fixes
branch
from
b11af16 to
caca1bb
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 12, 2026
…ce tests (#20425) ## Summary - **TXE scope fix**: When `from` is the zero address, TXE now returns `[]` (empty scopes, deny-all) instead of `undefined` (allow-all). This matches the behavior of `BaseWallet.scopesFor()` in the PXE/wallet path, where the zero address produces an empty scope list that causes `ensureContractSynced` to skip sync entirely. - **ContractSyncService tests**: Adds 19 unit tests covering scope-aware caching, cache invalidation (wipe/discard), overrides, concurrency, and error handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fromis the zero address, TXE now returns[](empty scopes, deny-all) instead ofundefined(allow-all). This matches the behavior ofBaseWallet.scopesFor()in the PXE/wallet path, where the zero address produces an empty scope list that causesensureContractSyncedto skip sync entirely.