fix: misc minor contract fixes#20423
Open
LHerskind wants to merge 9 commits intolh/escape-hatch-snapshotfrom
Open
fix: misc minor contract fixes#20423LHerskind wants to merge 9 commits intolh/escape-hatch-snapshotfrom
LHerskind wants to merge 9 commits intolh/escape-hatch-snapshotfrom
Conversation
This was referenced Feb 12, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Maddiaa0
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixing misc minor issues:
TallySlashingProposerhad wrong order of argumentsTallySlashingProposerhad a explicit MUST be >0 in the comments but did not enforce it in the codeFeeConfigfeeHeadersin theFeeLib, was not removed when we refactored the storage long agoCandidateJoinedsince it was just a immutable valueproposerIndexandslotfrom theverifyAttestationsgetVoteson the tally slashing proposergetRoundon the tally slashing proposer had a few unnecessary check that the_getRoundDatawas already doing.