Skip to content

fix: misc minor contract fixes#20423

Open
LHerskind wants to merge 9 commits intolh/escape-hatch-snapshotfrom
lh/misc-contract-fixes
Open

fix: misc minor contract fixes#20423
LHerskind wants to merge 9 commits intolh/escape-hatch-snapshotfrom
lh/misc-contract-fixes

Conversation

@LHerskind
Copy link
Contributor

@LHerskind LHerskind commented Feb 12, 2026

Fixing misc minor issues:

  • The EIP-712 comment in TallySlashingProposer had wrong order of arguments
  • The TallySlashingProposer had a explicit MUST be >0 in the comments but did not enforce it in the code
  • Comment said 64 bits for a 32 bit value in FeeConfig
  • Unused feeHeaders in the FeeLib, was not removed when we refactored the storage long ago
  • Require the bond of the escape hatch to be > 0
  • Remove the amount from the CandidateJoined since it was just a immutable value
  • Remove the unsed proposerIndex and slot from the verifyAttestations
  • Ensure that we do not get stale values from getVotes on the tally slashing proposer
  • The getRound on the tally slashing proposer had a few unnecessary check that the _getRoundData was already doing.

Copy link
Contributor Author

LHerskind commented Feb 12, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@LHerskind LHerskind changed the title fix: f2 fix: misc minor contract fixes Feb 12, 2026
@LHerskind LHerskind marked this pull request as ready for review February 12, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants