Open
Conversation
nono
force-pushed
the
add-cli
branch
2 times, most recently
from
f85def7 to
b4fdcfb
Compare
implausible
suggested changes
Oct 25, 2018
package.json
Outdated
| "bugs": { | ||
| "url": "https://github.com/axosoft/node-simple-file-watcher/issues" | ||
| }, | ||
| "bin": "nsfw.js", |
Contributor
There was a problem hiding this comment.
Can you move this bad boy into the src directory with the rest of the code. Perhaps in a new src/bin/ directory.
Then the actual target of "bin" is going to be lib/src/bin/nsfw.js
implausible
reviewed
Oct 25, 2018
| }, | ||
| "bin": "lib/src/bin/nsfw.js", | ||
| "files": [ | ||
| "nsfw.js", |
Contributor
There was a problem hiding this comment.
I think this line is now irrelevant.
Contributor
|
So at work I have access only to a linux machine. Do you think it would be easy to write at least 1 test confirming that the CLI package works on each operating system as expected? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI can be used like this:
It should help for testing nsfw and reporting issues.
Related issue: #19