Nodejs process doesnt close after stopping#189
Open
julianmesa-gitkraken wants to merge 3 commits intoAxosoft:masterfrom
Open
Nodejs process doesnt close after stopping#189julianmesa-gitkraken wants to merge 3 commits intoAxosoft:masterfrom
julianmesa-gitkraken wants to merge 3 commits intoAxosoft:masterfrom
Conversation
Enhances robustness in options processing by validating error callback and excluded paths. Ensures proper thread joining and queue management during object destruction to prevent potential crashes. Refines error messages for clarity and user understanding, providing more informative feedback in case of failures. Adds checks to ensure queue and interface are valid before calling methods on them.
86fb66a to
aa85e01
Compare
Improves excluded path validation by normalizing paths before comparison, ensuring accurate subdirectory checks. Updates debounceMS validation to include an upper bound, preventing excessively long debounce intervals. Provides a more robust and consistent way of retrieving excluded paths, handling cases where the underlying implementation might not support it. Fixes a bug where file modification detection was not working correctly due to incorrect time comparison.
aa85e01 to
fdba49b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes and improvements: