feat: Add memory.dataUTF8() built-in function#2974
Open
geraintluff wants to merge 4 commits intoAssemblyScript:mainfrom
Open
feat: Add memory.dataUTF8() built-in function#2974geraintluff wants to merge 4 commits intoAssemblyScript:mainfrom
memory.dataUTF8() built-in function#2974geraintluff wants to merge 4 commits intoAssemblyScript:mainfrom
Conversation
geraintluff
commented
Jan 13, 2026
| let arrayNullTerminated = new Uint8Array(array.length + 1); | ||
| arrayNullTerminated.set(array); | ||
| offset = compiler.addAlignedMemorySegment(arrayNullTerminated, 1).offset; | ||
| // FIXME: what if recompiles happen? recompiles are bad. |
Author
There was a problem hiding this comment.
This FIXME is copied from the memory.data<T> implementation just above. Tbh I don't understand it, but if it's a problem there, then it's a problem here.
Author
|
If you want to see why I proposed this: here's a diff |
memory.dataUTF8() built-in functionmemory.dataUTF8() built-in function
dcodeIO
reviewed
Jan 14, 2026
Author
|
@dcodeIO I wrote a It silently encodes unpaired surrogates (WTF16) as code-points, which is the same behaviour as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #2972, providing a way to embed UTF-8 string constants.
Rationale
UTF-16 strings are naturally embedded in the data section if you use a string constant (
"...") in your code.If what you need is a UTF-8 string, then storing as WTF-16 wastes binary space and execution time.
Current workaround
You can currently achieve the same result by using
memory.data<u8>([..., 0])with the appropriate UTF-8 bytes, but reading/changing/reviewing this code is more difficult.Changes
memory.dataUTF8(<string constant>)function in standard librarytests/compiler/memory.tsnpm run checkshows no errors for the files I touched. (Existing errors intests/import/index.tsare unrelated.)