fix: generate correct override stub for interface when implementation from base class#2969
Open
HerrCai0907 wants to merge 2 commits intoAssemblyScript:mainfrom
Conversation
Member
|
I'm not sure if I can say anything with confidence one way or another, to be honest. I'm not that familiar with how propagation across classes/interfaces is supposed to work... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when class implements interface by its base class member, the original design will not manage it.
For example,
class
Cimplements interfaceI, but when creatingI#foooverride stub, it will only search the member of class C. which does not includeBase#foo.This PR wants to split override (by extends) and implementation (by implements). Handling override needs to check whether the current class overrides the base class method. Handling implementation needs to check whether the current class and its base class implements the interface method.