feat: part 1 of TLS configs: external TLS#121
Open
fkywong wants to merge 11 commits intoAltinity:mainfrom
Open
feat: part 1 of TLS configs: external TLS#121fkywong wants to merge 11 commits intoAltinity:mainfrom
fkywong wants to merge 11 commits intoAltinity:mainfrom
Conversation
fkywong
commented
Feb 14, 2026
| """Get the list of pods in the specified namespace and return in a list.""" | ||
|
|
||
| pods = run(cmd=f"minikube kubectl -- get pods -n {namespace} -o json") | ||
| pods = run(cmd=f"kubectl get pods -n {namespace} -o json") |
Contributor
Author
There was a problem hiding this comment.
Every other kubectl command wrapped with run(...) in this file is already not prefixed with minikube, so I think this change is safe.
Collaborator
|
Thank you, please give us some time to review. |
fkywong
force-pushed
the
fwong/tls-config
branch
from
118fada to
113e40b
Compare
fkywong
commented
Feb 25, 2026
Comment on lines
-193
to
+225
| {{ $key }}: "{{ $value }}" | ||
| {{- $valueIsNumeric := regexMatch "^[0-9]+$" ( $value | toString ) }} | ||
| {{ $key }}: {{ ternary $value ( $value | quote ) $valueIsNumeric }} |
Contributor
Author
There was a problem hiding this comment.
Tangential optimization to not wrap every clickhouse.settings.* value in quotes. Instead, if the value is fully numeric, it won't quote the value, allowing the type to remain as a number.
This allows the generated spec to look similar to the documented example:
spec:
configuration:
clusters:
# ...
settings:
tcp_port: 9000
tcp_port_secure: 9440
https_port: 8443
fkywong
force-pushed
the
fwong/tls-config
branch
from
d778768 to
4361f67
Compare
fkywong
force-pushed
the
fwong/tls-config
branch
from
4361f67 to
db74055
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/steps/kubernetes.py: remove_chi_finalizers(...)).(Screenshot of the
t10-tlsClickHouse cluster from the TestFlows smoke test fixtures showing HTTPS.)Tests
All existing and new test fixtures/scenarios pass locally:
References