Fix distributed_ddl replicas_path mismatch causing ON CLUSTER DDL to hang #1922
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hang
The operator generates a custom <distributed_ddl><path> per CHI
(e.g. /clickhouse/{chi-name}/task_queue/ddl) but does not set
<replicas_path>. ClickHouse 25.8+ falls back to the default
replicas_path from config.xml (/clickhouse/task_queue/replicas),
which is in a different subtree. This causes the DDL workers to
never pick up tasks, making any CREATE TABLE ... ON CLUSTER hang
indefinitely.
Add <replicas_path> alongside <path> so both use the same
per-CHI subtree in ZooKeeper/Keeper.
Member
|
It should be only applied for versions >= 25.8.10 to avoid unnecessary restarts. Maybe we can do it via addons.rules configuration instead of the code. Like this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operator generates a custom <distributed_ddl> per CHI (e.g. /clickhouse/{chi-name}/task_queue/ddl) but does not set <replicas_path>. ClickHouse 25.8+ falls back to the default replicas_path from config.xml (/clickhouse/task_queue/replicas), which is in a different subtree. This causes the DDL workers to never pick up tasks, making any CREATE TABLE ... ON CLUSTER hang indefinitely.
Add <replicas_path> alongside so both use the same per-CHI subtree in ZooKeeper/Keeper.
Important items to consider before making a Pull Request
Please check items PR complies to:
next-releasebranch, not intomasterbranch1. More info--
1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into
masterbranch, but it has to be confirmed by project's maintainer.