[Plan] fix(frontend): Registry commit fails after hard refresh#3963
Merged
mmabrouk merged 9 commits intorelease/v0.94.1from Mar 12, 2026
Merged
[Plan] fix(frontend): Registry commit fails after hard refresh#3963mmabrouk merged 9 commits intorelease/v0.94.1from
mmabrouk merged 9 commits intorelease/v0.94.1from
Conversation
Add planning workspace documenting the root cause and fix for the registry page commit failure after hard refresh. The frontend incorrectly routes commits through the legacy endpoint when playgroundNodesAtom is empty.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Refine the registry commit bug plan after review to keep the first implementation scoped to the broken commit flow. Defer create and delete follow-ups until their refresh behavior is reproduced.
- runnableBridge.isDirty now only checks the molecule that owns the entity (has data for it), avoiding false positives from probing all types - legacyAppRevision isDirty returns false when server data not yet loaded instead of prematurely reporting dirty - workflow isDirty formatting cleanup (no logic change)
…only Remove unused commit logic that was moved to playgroundController. Keep only the revision polling utilities (newestRevisionForVariantAtomFamily, waitForNewRevision) used by createVariant flow.
…port Remove unused legacy commit logic. Keep only the variant modal adapter with runnableBridge-based commit context for EntityCommitModal.
…ontroller Clean up dead code paths that were superseded by workflow-based commits. The controller now uses commitWorkflowRevisionAtom and createWorkflowVariantAtom from the workflow entity module.
…EntityBridge Also remove unused imports from CommitVariantChangesModal.
Align exports with simplified commit.ts - remove references to deleted commit logic while keeping polling utilities and molecule API.
Contributor
Railway Preview Environment
Updated at 2026-03-12T09:59:33.421Z |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PUT /variants/{id}/parametersendpoint instead ofPOST /preview/workflows/revisions/commit, causing abadly formed hexadecimal UUID stringerror.controllerCommitRevisionAtomchecksplaygroundNodesAtom(in-memory, empty after refresh) to decide workflow vs legacy. A secondary bug passesslugasvariantIdmaking the legacy path fail outright.playgroundNodesAtomlookup withgetRunnableTypeResolver()(already exists, already returns"workflow"for all OSS entities). Clean up the commit modal payload. Changes in 2 files.Planning Docs
Full analysis and step-by-step plan in
docs/design/registry-commit-fix/:context.mdplan.mdresearch.mdstatus.mdScope
Frontend only. No backend changes needed — the workflow commit endpoint works fine, the frontend just wasn't routing to it.