Skip to content

[Plan] fix(frontend): Registry commit fails after hard refresh#3963

Merged
mmabrouk merged 9 commits intorelease/v0.94.1from
fix/registry-commit
Mar 12, 2026
Merged

[Plan] fix(frontend): Registry commit fails after hard refresh#3963
mmabrouk merged 9 commits intorelease/v0.94.1from
fix/registry-commit

Conversation

@mmabrouk
Copy link
Member

@mmabrouk mmabrouk commented Mar 11, 2026

Summary

  • Bug: Committing from the registry page after a hard refresh hits the legacy PUT /variants/{id}/parameters endpoint instead of POST /preview/workflows/revisions/commit, causing a badly formed hexadecimal UUID string error.
  • Root cause: controllerCommitRevisionAtom checks playgroundNodesAtom (in-memory, empty after refresh) to decide workflow vs legacy. A secondary bug passes slug as variantId making the legacy path fail outright.
  • Proposed fix: Replace the playgroundNodesAtom lookup with getRunnableTypeResolver() (already exists, already returns "workflow" for all OSS entities). Clean up the commit modal payload. Changes in 2 files.

Planning Docs

Full analysis and step-by-step plan in docs/design/registry-commit-fix/:

File Contents
context.md Root cause analysis — the two bugs and why they interact
plan.md 4-step execution plan with exact file/line references
research.md Full call chain from button click to API request
status.md Progress tracker

Scope

Frontend only. No backend changes needed — the workflow commit endpoint works fine, the frontend just wasn't routing to it.


Open with Devin

Add planning workspace documenting the root cause and fix for the
registry page commit failure after hard refresh. The frontend
incorrectly routes commits through the legacy endpoint when
playgroundNodesAtom is empty.
@vercel
Copy link

vercel bot commented Mar 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Ready Ready Preview, Comment Mar 12, 2026 9:02am

Request Review

Refine the registry commit bug plan after review to keep the first
implementation scoped to the broken commit flow. Defer create and
delete follow-ups until their refresh behavior is reproduced.
- runnableBridge.isDirty now only checks the molecule that owns the entity
  (has data for it), avoiding false positives from probing all types
- legacyAppRevision isDirty returns false when server data not yet loaded
  instead of prematurely reporting dirty
- workflow isDirty formatting cleanup (no logic change)
…only

Remove unused commit logic that was moved to playgroundController.
Keep only the revision polling utilities (newestRevisionForVariantAtomFamily,
waitForNewRevision) used by createVariant flow.
…port

Remove unused legacy commit logic. Keep only the variant modal adapter
with runnableBridge-based commit context for EntityCommitModal.
…ontroller

Clean up dead code paths that were superseded by workflow-based commits.
The controller now uses commitWorkflowRevisionAtom and createWorkflowVariantAtom
from the workflow entity module.
…EntityBridge

Also remove unused imports from CommitVariantChangesModal.
Align exports with simplified commit.ts - remove references to deleted
commit logic while keeping polling utilities and molecule API.
@mmabrouk mmabrouk marked this pull request as ready for review March 12, 2026 09:01
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. bug Something isn't working labels Mar 12, 2026
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 4 additional findings in Devin Review.

Open in Devin Review

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026

Railway Preview Environment

Status Destroyed (PR closed)

Updated at 2026-03-12T09:59:33.421Z

@mmabrouk mmabrouk changed the base branch from main to release/v0.94.1 March 12, 2026 09:59
@mmabrouk mmabrouk merged commit c86582c into release/v0.94.1 Mar 12, 2026
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants