fix: remove /preview/ prefix from frontend API calls#3924
fix: remove /preview/ prefix from frontend API calls#3924jangjohn wants to merge 3 commits intoAgenta-AI:mainfrom
Conversation
|
@jangjohn is attempting to deploy a commit to the agenta projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@mmabrouk I've also updated stale comments that still referenced /preview/ paths. Could you approve the workflows so CI can run? Thanks! |
There was a problem hiding this comment.
🔴 invokeApplication still uses /preview/ prefix while invokeEvaluator was updated
The invokeEvaluator function at web/oss/src/services/workflows/invoke.ts:107 was correctly updated to remove the /preview/ prefix, but the adjacent invokeApplication function at line 149 was not updated and still uses ${getAgentaApiUrl()}/preview/workflows/invoke. Since the PR's intent is to remove the /preview/ prefix from all API routes, this is an incomplete transformation that will cause invokeApplication to call a different (old) endpoint than invokeEvaluator, leading to 404 errors or routing mismatches when the backend /preview/ routes are removed.
(Refers to line 149)
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
🔴 Playwright testset test still intercepts old /api/preview/testsets/query route
In web/oss/tests/playwright/acceptance/testsset/index.ts:44, the page.waitForResponse still checks for /api/preview/testsets/query, but the actual API endpoint has been changed to /api/testsets/query (the fetchTestsetsWindow and fetchTestsetsList functions were updated). This means the test will time out waiting for a response that will never match the old URL pattern, causing test failures.
(Refers to line 44)
Was this helpful? React with 👍 or 👎 to provide feedback.
fix: remove /preview/ prefix from frontend API calls
Closes #3831
Removes the
/preview/prefix from all frontend API calls across the web codebase, replacing them with canonical routes.Changes
web/oss/src/,web/packages/, andweb/tests/.tsand.tsxfiles changed/preview/environments/intentionally left unchanged (no canonical equivalent)Notes