Open
Conversation
Ilios is an open source application built to manage the curriculum of medical, pharmacy, dental, and nursing health science degrees. It is sponsored by UCSF and used at universities around the world.
In my experimentation, I've discovered that though the promise returned from `store.query()` does have array-like methods on it, the actual `AdapterPopulatedRecordArray` is what the promise *resolves to*. For example, the `length` property of the object returned from `store.query` will always be `0`. The object which the promise resolves to will represent the actual length of the records that were queried.
The documentation for `store.query` states plainly that the AdapterPopulatedRecordArray is the *resolution* of the promise, but the documentation here misrepresented that.
For example, the original code actually would behave like this:
```javascript
// GET /users?isAdmin=true
var admins = store.query('user', { isAdmin: true });
admins.then(function() {
console.log(admins.get("length")); // Throws: "admins.get" is not a function
});
```
This prevents a timeout if build and test take longer than 10 minutes.
…ntend Add partner test for the ilios frontend
I was mucking about with google-closure-compiler and it tripped up on these deletes that are not for properties. Looking at the blame, looks like they may have been left over from some find/replacing.
[DOC release] Change misleading documentation for AdapterPopulatedRecordArray
[BUGFIX] fix promise labels
warp-drive-data#5627) * Feed options through HasManyReference. * Feed options through BelongsToReference. * Record Data: Feed options through HasManyReference. * Record Data: Feed options through BelongsToReference. * Test HasManyReference. * Test BelongsToReference. * Improve documentation.
cleanup code climate config
[FEAT RecordData] turn on the build-flag by default
- Add test for capturing error details
…uest-response-info-with-abort-error Include request/response info with Abort error
[BUGFIX] fix deprecation for store entry methods
…partner-tests Add a couple of ED-related add-ons as external partner tests
* [CHORE] move ilios external-partner test to first in queue * [CHORE] organize all jobs longest to shortest * move production job up a slot * update comments
[CHORE] fix up module imports
This PR makes changes the known to be empty behavior. It allows a second get request without an include string will keep any relationship data that the model knows about.
* Don't reopen class, use original relationship * Don't use Ember.run
According to RELEASE.md, release is not done through this tool. Let's remove it, as it triggers a long list of warnings.
Bumps [@types/ember-test-helpers](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ember-test-helpers) from 1.0.4 to 1.0.5. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ember-test-helpers) Signed-off-by: dependabot[bot] <support@dependabot.com>
Bumps [@types/ember__test-helpers](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ember__test-helpers) from 0.7.7 to 0.7.8. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ember__test-helpers) Signed-off-by: dependabot[bot] <support@dependabot.com>
Bumps [@types/ember](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ember) from 3.0.27 to 3.0.29. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ember) Signed-off-by: dependabot[bot] <support@dependabot.com>
integration/relationships/inverse-relationships-test
move ember-fetch to a peer-dependency fix jsonapi adapter tests add tests for fetch
* Fix lint error * Fix `_requireBuildPackages` error * Reset yarn.lock from master There seems to be some issues in the yarn.lock To solve them I ran: - `git checkout master yarn.lock` - `yarn` Throw an error in case of dependency mismatch (#2) * Throw an error in case of dependency mismatch An app (or addon) that consumes ember-data should have: - either jquery - or ember-fetch version 6.0.0 or above Throw a build error if it's not the case. * Remove ember-fetch as a peerDependency Move ember-fetch to dependencies (#3) Indeed, two `ember-fetch`'s modules are imported in rest-adapter.
Bumps [ember-fetch](https://github.com/ember-cli/ember-fetch) from 6.4.0 to 6.5.0. - [Release notes](https://github.com/ember-cli/ember-fetch/releases) - [Changelog](https://github.com/ember-cli/ember-fetch/blob/master/CHANGELOG.md) - [Commits](ember-cli/ember-fetch@v6.4.0...v6.5.0) Signed-off-by: dependabot[bot] <support@dependabot.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A test