From 31edbb811a9a82c2629c2ca162b657fdcd47e0bd Mon Sep 17 00:00:00 2001 From: Christophe Dervieux Date: Mon, 2 Mar 2026 20:20:15 +0100 Subject: [PATCH] Fix CI: install rsvg-convert and verapdf when running all tests The update-test-timing.yml and daily test-smokes.yml schedule runs pass `buckets: ""` (all tests), but rsvg-convert and verapdf were only installed when `buckets` contained specific bucket names. This caused 4 pdf-standard/ua-* tests to fail every run since Jan 26. Use the same `format('{0}', inputs.buckets) == ''` pattern already used elsewhere in this workflow to detect all-tests mode. Fixes weekly timing update failures and daily schedule failures. --- .github/workflows/test-smokes.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-smokes.yml b/.github/workflows/test-smokes.yml index 2aa47a81cf..5adfde80c0 100644 --- a/.github/workflows/test-smokes.yml +++ b/.github/workflows/test-smokes.yml @@ -141,7 +141,7 @@ jobs: - name: Install rsvg-convert for SVG conversion tests # Only do it on linux runner, and only if we are running the relevant tests - if: runner.os == 'Linux' && (contains(inputs.buckets, 'render-pdf-svg-conversion') || contains(inputs.buckets, 'pdf-standard')) + if: runner.os == 'Linux' && (format('{0}', inputs.buckets) == '' || contains(inputs.buckets, 'render-pdf-svg-conversion') || contains(inputs.buckets, 'pdf-standard')) run: | sudo apt-get update -y sudo apt-get install -y librsvg2-bin @@ -202,7 +202,7 @@ jobs: quarto install tinytex - name: Install veraPDF for PDF standard validation - if: runner.os == 'Linux' && contains(inputs.buckets, 'pdf-standard') + if: runner.os == 'Linux' && (format('{0}', inputs.buckets) == '' || contains(inputs.buckets, 'pdf-standard')) env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: |