From 23c07822ef0d00ab86b60a8d3f8c6a1e4abdb113 Mon Sep 17 00:00:00 2001 From: Rom1-B Date: Tue, 24 Feb 2026 11:05:39 +0100 Subject: [PATCH] Fix(CI): tests --- tests/Units/GroupEscalationTest.php | 13 ++++++------- tests/Units/TicketTest.php | 8 ++++++-- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/tests/Units/GroupEscalationTest.php b/tests/Units/GroupEscalationTest.php index 42fd230a..8db2e4fc 100644 --- a/tests/Units/GroupEscalationTest.php +++ b/tests/Units/GroupEscalationTest.php @@ -565,11 +565,10 @@ public function testTechGroupAttributionAddTicket() ], ]); - $ticket_user = new Ticket_User(); - $this->assertEquals($provider['add_expected']['user_ticket'], count($ticket_user->find(['tickets_id' => $ticket->getID(), 'type' => CommonITILActor::ASSIGN]))); + $this->assertEquals($provider['add_expected']['user_ticket'], countElementsInTable(Ticket_User::getTable(), ['tickets_id' => $ticket->getID(), 'type' => CommonITILActor::ASSIGN])); $group_ticket = new Group_Ticket(); - $this->assertEquals($provider['add_expected']['group_ticket'], count($group_ticket->find(['tickets_id' => $ticket->getID(), 'type' => CommonITILActor::ASSIGN]))); + $this->assertEquals($provider['add_expected']['group_ticket'], countElementsInTable(Group_Ticket::getTable(), ['tickets_id' => $ticket->getID(), 'type' => CommonITILActor::ASSIGN])); if ($provider['conf']['use_assign_user_group_creation'] === 1) { $group = $group_ticket->getFromDBByCrit(['tickets_id' => $ticket->getID(), 'type' => CommonITILActor::ASSIGN]); @@ -620,18 +619,18 @@ public function testTechGroupAttributionAddTicket() ], ); - $this->assertEquals($provider['update_expected']['user_ticket'], count($ticket_user->find(['tickets_id' => $ticket->getID(), 'type' => CommonITILActor::ASSIGN])), 'Failed with config: ' . json_encode($provider['conf'])); - $this->assertEquals($provider['update_expected']['group_ticket'], count($group_ticket->find(['tickets_id' => $ticket->getID(), 'type' => CommonITILActor::ASSIGN])), 'Failed with config: ' . json_encode($provider['conf'])); + $this->assertEquals($provider['update_expected']['user_ticket'], countElementsInTable(Ticket_User::getTable(), ['tickets_id' => $ticket->getID(), 'type' => CommonITILActor::ASSIGN]), 'Failed with config: ' . json_encode($provider['conf'])); + $this->assertEquals($provider['update_expected']['group_ticket'], countElementsInTable(Group_Ticket::getTable(), ['tickets_id' => $ticket->getID(), 'type' => CommonITILActor::ASSIGN]), 'Failed with config: ' . json_encode($provider['conf'])); if ($provider['conf']['use_assign_user_group_modification'] === 1) { if ($provider['conf']['use_assign_user_group'] === 1) { $group = $group_ticket->getFromDBByCrit(['tickets_id' => $ticket->getID(), 'type' => CommonITILActor::ASSIGN, 'groups_id' => $group2->getID()]); - $this->assertTrue($group); + $this->assertTrue($group, 'Failed with config: ' . json_encode($provider['conf'])); } if ($provider['conf']['use_assign_user_group'] === 2) { $group = $group_ticket->getFromDBByCrit(['tickets_id' => $ticket->getID(), 'type' => CommonITILActor::ASSIGN, 'groups_id' => $group4->getID()]); - $this->assertTrue($group); + $this->assertTrue($group, 'Failed with config: ' . json_encode($provider['conf'])); } } } diff --git a/tests/Units/TicketTest.php b/tests/Units/TicketTest.php index 3eac308a..bd284550 100644 --- a/tests/Units/TicketTest.php +++ b/tests/Units/TicketTest.php @@ -872,6 +872,8 @@ public function testAddSolutionWithMandatoryTemplateFields() 'name' => 'test_requester', 'realname' => 'Test Requester', 'firstname' => 'User', + '_entities_id' => 0, + '_profiles_id' => 4, ]); $user_id = $user->getID(); @@ -1001,7 +1003,8 @@ public function testAssignMeWithMandatoryTemplateFields() $requester = $this->createItem('User', [ 'name' => 'requester_test', 'firstname' => 'Requester', - 'entities_id' => 0, + '_entities_id' => 0, + '_profiles_id' => 4, ]); $requester_id = $requester->getID(); $this->assertGreaterThan(0, $requester_id); @@ -1164,7 +1167,8 @@ public function testHistoryButtonEscalationWithMandatoryTemplateFields() $requester = $this->createItem('User', [ 'name' => 'requester_history_test', 'firstname' => 'Requester', - 'entities_id' => 0, + '_entities_id' => 0, + '_profiles_id' => 4, ]); $requester_id = $requester->getID(); $this->assertGreaterThan(0, $requester_id);