From 6c29785ce43ef52578803f2d25219378c48be559 Mon Sep 17 00:00:00 2001 From: iscai-msft Date: Fri, 27 Feb 2026 12:22:53 -0500 Subject: [PATCH 1/3] remove enum padding --- .../generator/pygen/preprocess/__init__.py | 23 ++++--------------- .../pygen/preprocess/python_mappings.py | 2 -- 2 files changed, 5 insertions(+), 20 deletions(-) diff --git a/packages/http-client-python/generator/pygen/preprocess/__init__.py b/packages/http-client-python/generator/pygen/preprocess/__init__.py index 315d8ff9078..0d772315487 100644 --- a/packages/http-client-python/generator/pygen/preprocess/__init__.py +++ b/packages/http-client-python/generator/pygen/preprocess/__init__.py @@ -272,25 +272,12 @@ def update_types(self, yaml_data: list[dict[str, Any]]) -> None: type["description"] = update_description(type.get("description", ""), type["name"]) type["snakeCaseName"] = to_snake_case(type["name"]) if type.get("values"): - # we're enums - values_to_add = [] + # we're enums - enum values are UPPER_CASE so no padding needed for reserved words for value in type["values"]: - padded_name = self.pad_reserved_words(value["name"].lower(), PadType.ENUM_VALUE, value).upper() - if self.version_tolerant: - if padded_name[0] in "0123456789": - padded_name = "ENUM_" + padded_name - value["name"] = padded_name - else: - if value["name"] != padded_name: - values_to_add.append( - update_enum_value( - name=padded_name, - value=value["value"], - description=value["description"], - enum_type=value["enumType"], - ) - ) - type["values"].extend(values_to_add) + upper_name = value["name"].upper() + if upper_name[0] in "0123456789": + upper_name = "ENUM_" + upper_name + value["name"] = upper_name # add type for reference for v in HEADERS_CONVERT_IN_METHOD.values(): diff --git a/packages/http-client-python/generator/pygen/preprocess/python_mappings.py b/packages/http-client-python/generator/pygen/preprocess/python_mappings.py index d81bee8134d..c9621498437 100644 --- a/packages/http-client-python/generator/pygen/preprocess/python_mappings.py +++ b/packages/http-client-python/generator/pygen/preprocess/python_mappings.py @@ -56,7 +56,6 @@ class PadType(str, Enum): ENUM_CLASS = "Enum" METHOD = "_method" PARAMETER = "_parameter" - ENUM_VALUE = "_enum" PROPERTY = "_property" OPERATION_GROUP = "Operations" @@ -183,7 +182,6 @@ class PadType(str, Enum): PadType.MODEL: ["enum", *_always_reserved], PadType.PROPERTY: ["self", *_always_reserved], PadType.ENUM_CLASS: ["enum", *_always_reserved], - PadType.ENUM_VALUE: ["mro", *_always_reserved], PadType.OPERATION_GROUP: [*_always_reserved], } From fd9acd82e57acf0cce5f53f4fa638423deb50d09 Mon Sep 17 00:00:00 2001 From: iscai-msft Date: Fri, 27 Feb 2026 12:23:29 -0500 Subject: [PATCH 2/3] add changeset --- .../changes/python-removeEnumPadding-2026-1-27-12-23-22.md | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 .chronus/changes/python-removeEnumPadding-2026-1-27-12-23-22.md diff --git a/.chronus/changes/python-removeEnumPadding-2026-1-27-12-23-22.md b/.chronus/changes/python-removeEnumPadding-2026-1-27-12-23-22.md new file mode 100644 index 00000000000..ae32b998a5d --- /dev/null +++ b/.chronus/changes/python-removeEnumPadding-2026-1-27-12-23-22.md @@ -0,0 +1,7 @@ +--- +changeKind: feature +packages: + - "@typespec/http-client-python" +--- + +Remove enum value padding because we generate our enum value names with upper case so there is no need \ No newline at end of file From 5187325d695efb92b2e8432f122bb474fc8a2845 Mon Sep 17 00:00:00 2001 From: iscai-msft Date: Fri, 27 Feb 2026 14:16:39 -0500 Subject: [PATCH 3/3] fix pylint --- .../http-client-python/generator/pygen/preprocess/__init__.py | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/http-client-python/generator/pygen/preprocess/__init__.py b/packages/http-client-python/generator/pygen/preprocess/__init__.py index 0d772315487..e2f8cf842b3 100644 --- a/packages/http-client-python/generator/pygen/preprocess/__init__.py +++ b/packages/http-client-python/generator/pygen/preprocess/__init__.py @@ -21,7 +21,6 @@ get_body_type_for_description, JSON_REGEXP, KNOWN_TYPES, - update_enum_value, )