diff --git a/src/Directory.Build.props b/src/Directory.Build.props index 2ae5e45..b850734 100644 --- a/src/Directory.Build.props +++ b/src/Directory.Build.props @@ -4,10 +4,11 @@ $(MSBuildProjectName) Eric Burcham + ../../StyleCopAnalyzers.ruleset Eric Burcham $([System.DateTime]::Now.Year) - 2023 © $(CopyrightStartYear) - $(CopyrightCurrentYear) Eric Burcham + 2023 True disable False @@ -18,42 +19,24 @@ DataJam $(MSBuildProjectName) net8.0 + True - 0.0.0 - true true true - - - - - True - - - - - 1702;CS1591;MSB3277;NETSDK1138;NU5104;NU1702;NU1803;NU1901;NU1902;NU1903 + true + 0.0.0 + all runtime; build; native; contentfiles; analyzers - - - - - - - - ../../StyleCopAnalyzers.ruleset - - diff --git a/src/Directory.Packages.props b/src/Directory.Packages.props index cf90b6f..099a4fa 100644 --- a/src/Directory.Packages.props +++ b/src/Directory.Packages.props @@ -23,7 +23,6 @@ - diff --git a/src/code/DataJam.Testing/IdentityStrategies/IIdentityStrategy.cs b/src/code/DataJam.Testing/IdentityStrategies/IIdentityStrategy.cs index af8915d..94a97c6 100644 --- a/src/code/DataJam.Testing/IdentityStrategies/IIdentityStrategy.cs +++ b/src/code/DataJam.Testing/IdentityStrategies/IIdentityStrategy.cs @@ -8,5 +8,7 @@ namespace DataJam.Testing; public interface IIdentityStrategy where T : class { + /// Assigns the identity values. + /// The entity to assign the identity value for. void Assign(T entity); } diff --git a/src/code/DataJam.Testing/IdentityStrategies/IdentityStrategy.cs b/src/code/DataJam.Testing/IdentityStrategies/IdentityStrategy.cs index b3187b7..51538f7 100644 --- a/src/code/DataJam.Testing/IdentityStrategies/IdentityStrategy.cs +++ b/src/code/DataJam.Testing/IdentityStrategies/IdentityStrategy.cs @@ -39,8 +39,7 @@ protected IdentityStrategy(Expression> propertyExpression) /// Gets or sets the last value of the identity for this Type. public TIdentity LastValue { get; protected set; } = default!; - /// Assigns the identity values. - /// The entity to assign the identity value for. + /// public void Assign(T entity) { _identitySetter.Invoke(entity); diff --git a/src/test-support/DataJam.TestSupport.EntityFrameworkCore/DataJam.TestSupport.EntityFrameworkCore.csproj b/src/test-support/DataJam.TestSupport.EntityFrameworkCore/DataJam.TestSupport.EntityFrameworkCore.csproj index 3b024af..f0975ab 100644 --- a/src/test-support/DataJam.TestSupport.EntityFrameworkCore/DataJam.TestSupport.EntityFrameworkCore.csproj +++ b/src/test-support/DataJam.TestSupport.EntityFrameworkCore/DataJam.TestSupport.EntityFrameworkCore.csproj @@ -1,9 +1,5 @@ - - $(NoWarn);NETSDK1206 - - diff --git a/src/test-support/DataJam.TestSupport.TestPatterns/DataJam.TestSupport.TestPatterns.csproj b/src/test-support/DataJam.TestSupport.TestPatterns/DataJam.TestSupport.TestPatterns.csproj index 02223c9..f3b83ca 100644 --- a/src/test-support/DataJam.TestSupport.TestPatterns/DataJam.TestSupport.TestPatterns.csproj +++ b/src/test-support/DataJam.TestSupport.TestPatterns/DataJam.TestSupport.TestPatterns.csproj @@ -1,9 +1,5 @@ - - $(NoWarn);NETSDK1206 - - diff --git a/src/test-support/DataJam.TestSupport/DataJam.TestSupport.csproj b/src/test-support/DataJam.TestSupport/DataJam.TestSupport.csproj index 77350aa..054d398 100644 --- a/src/test-support/DataJam.TestSupport/DataJam.TestSupport.csproj +++ b/src/test-support/DataJam.TestSupport/DataJam.TestSupport.csproj @@ -1,9 +1,5 @@ - - $(NoWarn);NETSDK1206 - - diff --git a/src/test-support/Directory.Build.props b/src/test-support/Directory.Build.props index 284a49e..5c3fdc7 100644 --- a/src/test-support/Directory.Build.props +++ b/src/test-support/Directory.Build.props @@ -4,22 +4,7 @@ - False - - - - - - - - - - - - - - - ../StyleCopAnalyzers.ruleset + CS1591 diff --git a/src/test-support/StyleCopAnalyzers.ruleset b/src/test-support/StyleCopAnalyzers.ruleset deleted file mode 100644 index 5875977..0000000 --- a/src/test-support/StyleCopAnalyzers.ruleset +++ /dev/null @@ -1,217 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/src/test-support/stylecop.json b/src/test-support/stylecop.json deleted file mode 100644 index 4826a89..0000000 --- a/src/test-support/stylecop.json +++ /dev/null @@ -1,66 +0,0 @@ -{ - // ACTION REQUIRED: You have successfully added this file to your project, but it - // will not take effect until additional steps are taken to enable it. See the - // following page for additional information: - // - // https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/EnableConfiguration.md - "$schema": "https://raw.githubusercontent.com/DotNetAnalyzers/StyleCopAnalyzers/master/StyleCop.Analyzers/StyleCop.Analyzers/Settings/stylecop.schema.json", - "settings": { - "documentationRules": { - "documentationCulture": "en-US", - "documentExposedElements": false, - "documentInterfaces": false, - "documentInternalElements": false, - "documentPrivateElements": false, - "documentPrivateFields": false, - "excludeFromPunctuationCheck": [ - // None here, for now. - ], - "fileNamingConvention": "stylecop", - "headerDecoration": "-----------------------------------------------------------------------", - "xmlHeader": true - }, - "indentation": { - "indentationSize": 4, - "tabSize": 4, - "useTabs": false - }, - "layoutRules": { - "allowConsecutiveUsings": false, - "newlineAtEndOfFile": "require" - }, - "maintainabilityRules": { - "topLevelTypes": [ - "class", - "delegate", - "enum", - "interface", - "struct" - ] - }, - "namingRules": { - "allowCommonHungarianPrefixes": true, - "allowedHungarianPrefixes": [ - // None here, for now. - ] - }, - "orderingRules": { - "blankLinesBetweenUsingGroups": "require", - "elementOrder": [ - "kind", - "constant", - "accessibility", - "static", - "readonly" - ], - "systemUsingDirectivesFirst": true, - "usingDirectivesPlacement": "insideNamespace" - }, - "readabilityRules": { - "allowBuiltInTypeAliases": false - }, - "spacingRules": { - // There are currently no supported spacing rules. - } - } -} diff --git a/src/tests/DataJam.EntityFrameworkCore.MsSql.IntegrationTests/DataJam.EntityFrameworkCore.MsSql.IntegrationTests.csproj b/src/tests/DataJam.EntityFrameworkCore.MsSql.IntegrationTests/DataJam.EntityFrameworkCore.MsSql.IntegrationTests.csproj index 0ec46dd..8780eec 100644 --- a/src/tests/DataJam.EntityFrameworkCore.MsSql.IntegrationTests/DataJam.EntityFrameworkCore.MsSql.IntegrationTests.csproj +++ b/src/tests/DataJam.EntityFrameworkCore.MsSql.IntegrationTests/DataJam.EntityFrameworkCore.MsSql.IntegrationTests.csproj @@ -1,9 +1,5 @@ - - $(NoWarn);NETSDK1206 - - diff --git a/src/tests/DataJam.EntityFrameworkCore.MySql.IntegrationTests/DataJam.EntityFrameworkCore.MySql.IntegrationTests.csproj b/src/tests/DataJam.EntityFrameworkCore.MySql.IntegrationTests/DataJam.EntityFrameworkCore.MySql.IntegrationTests.csproj index af0a83f..db84da6 100644 --- a/src/tests/DataJam.EntityFrameworkCore.MySql.IntegrationTests/DataJam.EntityFrameworkCore.MySql.IntegrationTests.csproj +++ b/src/tests/DataJam.EntityFrameworkCore.MySql.IntegrationTests/DataJam.EntityFrameworkCore.MySql.IntegrationTests.csproj @@ -1,9 +1,5 @@ - - $(NoWarn);NETSDK1206 - - diff --git a/src/tests/DataJam.EntityFrameworkCore.Sqlite.IntegrationTests/DataJam.EntityFrameworkCore.Sqlite.IntegrationTests.csproj b/src/tests/DataJam.EntityFrameworkCore.Sqlite.IntegrationTests/DataJam.EntityFrameworkCore.Sqlite.IntegrationTests.csproj index 415fddd..a2a35a1 100644 --- a/src/tests/DataJam.EntityFrameworkCore.Sqlite.IntegrationTests/DataJam.EntityFrameworkCore.Sqlite.IntegrationTests.csproj +++ b/src/tests/DataJam.EntityFrameworkCore.Sqlite.IntegrationTests/DataJam.EntityFrameworkCore.Sqlite.IntegrationTests.csproj @@ -1,9 +1,5 @@ - - $(NoWarn);NETSDK1206 - - diff --git a/src/tests/DataJam.Testing.UnitTests/DataJam.Testing.UnitTests.csproj b/src/tests/DataJam.Testing.UnitTests/DataJam.Testing.UnitTests.csproj index 87e6f69..093fbee 100644 --- a/src/tests/DataJam.Testing.UnitTests/DataJam.Testing.UnitTests.csproj +++ b/src/tests/DataJam.Testing.UnitTests/DataJam.Testing.UnitTests.csproj @@ -1,9 +1,5 @@ - - - - diff --git a/src/tests/Directory.Build.props b/src/tests/Directory.Build.props index 835a2f8..237581e 100644 --- a/src/tests/Directory.Build.props +++ b/src/tests/Directory.Build.props @@ -3,15 +3,16 @@ + + CS1591 + + + - - False - -