[PECOBLR-1655]Override do_ping for pool_pre_ping support#54
Merged
msrathore-db merged 2 commits intomainfrom Feb 20, 2026
Merged
[PECOBLR-1655]Override do_ping for pool_pre_ping support#54msrathore-db merged 2 commits intomainfrom
msrathore-db merged 2 commits intomainfrom
Conversation
Override do_ping() to catch any error and return False, letting SQLAlchemy invalidate the dead connection and create a new one. This is simpler and more robust than classifying errors in is_disconnect() — a health check should never raise. Also pin poetry to 2.0.8 in CI workflows to fix build failures. Closes #47 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
msrathore-db
requested review from
deeksha-db,
gopalldb,
jackyhu-db,
jayantsing-db,
jprakash-db,
madhav-db,
samikshya-db,
shivam2680 and
vikrantpuppala
as code owners
msrathore-db
changed the title
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
msrathore-db
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
jprakash-db
approved these changes
Feb 20, 2026
Collaborator
jprakash-db
left a comment
jprakash-db
left a comment
There was a problem hiding this comment.
LGTM. Thanks for making the changes
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Override do_ping() to catch any error and return False, letting SQLAlchemy invalidate the dead connection and create a new one. This is simpler and more robust than classifying errors in is_disconnect() — a health check should never raise.
Also pin poetry to 2.0.8 in CI workflows to fix build failures.
Closes #47