From aadca1ea447536314b0adf13edbe21180fac65b3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABlle=20Huisman?= Date: Sat, 7 Mar 2026 15:58:17 +0100 Subject: [PATCH] fix(shield): add alt to input addon image --- packages/core/shield/src/form.rs | 2 +- packages/methods/shield-oauth/src/actions/sign_in.rs | 6 +++++- packages/methods/shield-oidc/src/actions/sign_in.rs | 6 +++++- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/packages/core/shield/src/form.rs b/packages/core/shield/src/form.rs index be4dd12..541d5c3 100644 --- a/packages/core/shield/src/form.rs +++ b/packages/core/shield/src/form.rs @@ -36,7 +36,7 @@ pub enum InputValue { rename_all_fields = "camelCase" )] pub enum InputAddon { - Image { src: String }, + Image { alt: String, src: String }, Text { text: String }, } diff --git a/packages/methods/shield-oauth/src/actions/sign_in.rs b/packages/methods/shield-oauth/src/actions/sign_in.rs index 92e7dc7..bf6ee23 100644 --- a/packages/methods/shield-oauth/src/actions/sign_in.rs +++ b/packages/methods/shield-oauth/src/actions/sign_in.rs @@ -83,7 +83,11 @@ impl Action for OauthSignInAction { }), addon_start: provider .icon_url - .map(|icon_url| InputAddon::Image { src: icon_url }), + .as_ref() + .map(|icon_url| InputAddon::Image { + alt: format!("{} logo", provider.name()), + src: icon_url.clone(), + }), addon_end: None, }, ], diff --git a/packages/methods/shield-oidc/src/actions/sign_in.rs b/packages/methods/shield-oidc/src/actions/sign_in.rs index b77d125..68fccca 100644 --- a/packages/methods/shield-oidc/src/actions/sign_in.rs +++ b/packages/methods/shield-oidc/src/actions/sign_in.rs @@ -86,7 +86,11 @@ impl Action for OidcSignInAction { }), addon_start: provider .icon_url - .map(|icon_url| InputAddon::Image { src: icon_url }), + .as_ref() + .map(|icon_url| InputAddon::Image { + alt: format!("{} logo", provider.name()), + src: icon_url.clone(), + }), addon_end: None, }, ],