[Shape tools] Brush width should be hidden when Fill Style is set to "Fill Shape"

[pedropaulosuzuki]

Description
On shape tools, like the Rectangle, Rounded Rectangle, Ellipse and Freeform Shape, the "Brush width" parameter only changes the stroke size, so it would make more sense to hide it when the stroke is disabled (Fill Style: "Fill Shape"), like we already do in the Text Tool.

Edit: same for the Dash style, as it also only makes sense when there is a stroke.

[cameronwhite]

Since it isn't the last parameter, it might look weird to have it disappear and shift other parameters, so disabling could also be an option

[pedropaulosuzuki]

Since it isn't the last parameter, it might look weird to have it disappear and shift other parameters, so disabling could also be an option

Makes sense, but I think it also makes sense to leave it at the end, to be consistent with the Text Tool.

For example, in the Rectangle tool, I'd move the Shape Type to be the first item, then the Fill Style. And only when we have fill style, would we then have the Dash style and Stroke width parameters. I believe this makes more sense, as the Dash Style also only makes sense if we have a stroke in the first place.

How it is currently (rectangle tool):

[pedropaulosuzuki]

For the Rounded Rectangle tool, the first option would be the radius, as that's the most defining feature of the shape. Maybe it could come after Shape Type tho, to be consistent, but then it would be the second item from the start.

How it is currently (rounded rectangle tool):

[pedropaulosuzuki]

@cameronwhite I made a draft MR (#2019), see what you think about the change. I've not implemented the changes for the Freeform Shape yet, just for the shapes that use BaseEditEngine. Also, I made a small change to DashPatternBox, in order to have access to the separator and label visibility. Probably this should be exposed in a better way, but I made this for the time being.

[pedropaulosuzuki]

Small reminder that I didn't do the change to the Freeform Shape yet.