Feature/Fix gui name rename crash (#230)

* Refactor scalar source model and update ScalarAction

Convert ScalarSourceModel from QAbstractListModel to QStandardItemModel and introduce typed row items (NameItem, IdItem, Item) and a two-column layout (Name/ID). Datasets are now stored as rows (with helper Row class) and looked up by dataset ID via matching; getDatasets(), getDataset(), add/remove dataset and removeAllDatasets were adapted accordingly. Added getRowIndex() and removed the old per-dataset vector/updateData machinery. Update GUI data handling into Item/NameItem/IdItem (decoration, display and tooltip roles) and connect GUI name changes to emit updates. In ScalarAction: use getRowIndex() instead of rowIndex(), changed setCurrentSourceIndex parameter to std::int32_t, simplified getCurrentDataset() return, and left a TODO-commented dataset connection block. These changes centralize model data in QStandardItem rows, enable multi-column metadata, and simplify dataset lookup/removal by ID.

* Pass model reference to Item/Row

Give Item/NameItem/Row access to their parent ScalarSourceModel by adding a const ScalarSourceModel& parameter and storing it in Item::_scalarSourceModel. Update construction sites (appendRow/Row) to pass *this. Use the model reference in Item::data() to respect getShowFullPathName() and use getGuiName() for display. Add getScalarSourceModel() accessor. Also change getDatasets() to return by value and remove some dead/commented code. These changes allow items to query model state reliably and simplify row construction.

Author: ThomasKroes

src/ScalarAction.cpp

@@ -43,6 +43,7 @@ void ScalarAction::addDataset(const Dataset<DatasetImpl>& dataset)
 
     sourceModel.addDataset(dataset);
 
+    /* TODO: this connection is not removed when the dataset is removed from the model, but that should not cause any issues since the dataset will be invalid and the connection will not do anything in that case
     connect(&sourceModel.getDatasets().last(), &Dataset<DatasetImpl>::dataChanged, this, [this, dataset]() {
         const auto currentDataset = getCurrentDataset();
 
@@ -55,6 +56,8 @@ void ScalarAction::addDataset(const Dataset<DatasetImpl>& dataset)
             emit sourceDataChanged(dataset);
     });
 
+*/
+
     connect(&_magnitudeAction, &DecimalAction::valueChanged, this, [this, dataset](const float& value) {
         emit magnitudeChanged(value);
     });
@@ -72,20 +75,20 @@ Dataset<DatasetImpl> ScalarAction::getCurrentDataset()
     const auto currentSourceIndex = _sourceAction.getPickerAction().getCurrentIndex();
 
     if (currentSourceIndex < ScalarSourceModel::DefaultRow::DatasetStart)
-        return Dataset<DatasetImpl>();
+        return {};
 
     return scalarSourceModel.getDataset(currentSourceIndex);
 }
 
 void ScalarAction::setCurrentDataset(const Dataset<DatasetImpl>& dataset)
 {
-    const auto datasetRowIndex = _sourceAction.getModel().rowIndex(dataset);
+    const auto datasetRowIndex = _sourceAction.getModel().getRowIndex(dataset);
 
     if (datasetRowIndex >= 0)
         _sourceAction.getPickerAction().setCurrentIndex(datasetRowIndex);
 }
 
-void ScalarAction::setCurrentSourceIndex(bool sourceIndex)
+void ScalarAction::setCurrentSourceIndex(std::int32_t sourceIndex)
 {
     _sourceAction.getPickerAction().setCurrentIndex(sourceIndex);
 }

src/ScalarAction.h

@@ -51,7 +51,7 @@ class ScalarAction : public GroupAction
      * Set the current source index
      * @param sourceIndex Source index
      */
-    void setCurrentSourceIndex(bool sourceIndex);
+    void setCurrentSourceIndex(std::int32_t sourceIndex);
 
     /** Determines whether the scalar source is a constant */
     bool isSourceConstant() const;