Skip to content

Dark mode not applied correctly through the NavBar #130

@zoharma

Description

@zoharma

When using the NavBar Dark/Light mode button, the button does not correctly shifts between the modes.

The default Light mode shows the code as
<html lang="en" data-mode="light" class="light" style="color-scheme: light;">

While the Dark mode changes only the class and not the data-mode.
<html lang="en" data-mode="light" class="dark" style="color-scheme: light;">

We should update it so it does it changes the data-mode and color-scheme accordingly.

This was visible when I loaded the new theme DiamondDSTheme which relies on the data mode. It loads the light mode correctly, but on dark mode it falls back to MUI default dark colours.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions