-
-
Notifications
You must be signed in to change notification settings - Fork 15
Open
Description
The current CI workflows in .github/workflows/frontend-ci.yml and .github/workflows/python-app.yml are missing several critical quality checks.
Proposed Improvements:
1. Frontend (frontend-ci.yml)
- Strict Checks: Remove
continue-on-error: truefromLintandBuildsteps so that PRs cannot be merged with failures. - Formatting: Add a step to verify formatting using Prettier (e.g.,
npx prettier --check .). - Testing: Add a step to run tests if any exist (e.g.,
npm test). - Dependency Cache: Ensure Node.js cache is working correctly (already present but should be verified).
2. Python Backend (python-app.yml)
- Formatting: Add Ruff formatting check (
ruff format --check). - Testing: Add a step to run Django tests (
python manage.py test). - Branch Triggers: Update branch triggers to include
developor the main branch (currently points tolistOfMed). - Linting: Improve Ruff linting configuration or ensure it's running with the desired rules.
3. General Enhancements
- Pre-commit Hooks: Integrate
pre-commitinto CI to ensure all hooks pass before merging. - Consistency: Align branch triggers across all CI workflows.
Why is this needed?
To ensure code quality, consistency, and prevent regressions from being merged into the main branches.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
No status